The trailing output-index leads to cases where the user can't look-up the transaction ID in various systems.
[Qt] remove trailing output-index from transaction-id #7761
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/03/ui_txid changing 3 files +7 −7-
jonasschnelli commented at 9:25 AM on March 29, 2016: contributor
-
7d5e31a82b
[Qt] remove trailing output-index from transaction-id
The trailing output-index leads to cases where the user can't look-up the transaction ID in various systems.
- jonasschnelli added the label GUI on Mar 29, 2016
-
paveljanik commented at 9:28 AM on March 29, 2016: contributor
-
MarcoFalke commented at 9:29 AM on March 29, 2016: member
utACK 7d5e31a
-
paveljanik commented at 9:48 AM on March 29, 2016: contributor
Before: <img width="616" alt="screen shot 2016-03-29 at 11 45 22" src="https://cloud.githubusercontent.com/assets/6848764/14104154/e810992e-f5a3-11e5-8702-6ae9a0949f03.png">
After:
<img width="615" alt="screen shot 2016-03-29 at 11 45 56" src="https://cloud.githubusercontent.com/assets/6848764/14104169/f77584f6-f5a3-11e5-8e89-0c6616f3e4b0.png">
ACK https://github.com/bitcoin/bitcoin/pull/7761/commits/7d5e31a82bbf39b9e1a5f0afe5ad9cbf4df9778b
-
paveljanik commented at 9:50 AM on March 29, 2016: contributor
Several people like the previous behaviour though... This also changes the "Copy transaction ID" - to copy the txid only (from txid-voutnr).
-
sipa commented at 9:56 AM on March 29, 2016: member
Concept ACK. I expect the people who rely on the old behaviour to be much fewer than those that get confused by it.
-
laanwj commented at 10:18 AM on March 29, 2016: member
This also changes the "Copy transaction ID"
That's most of the point of this change. People paste that into block explorers and such, which don't know the format. Do you know of anyone (tools, applications and such) that adopted the txid-vout format besides us?
I mean theoretically I agree with you, the records represent a output not a transaction, and very strictly doing this is wrong. But it confuses so many people that I'm also convinced of this now.
-
paveljanik commented at 11:19 AM on March 29, 2016: contributor
I do not know anyone using it. And anyone using it can workaround it easily. Thus I already ACKed above.
-
petertodd commented at 12:40 PM on March 30, 2016: contributor
utACK https://github.com/bitcoin/bitcoin/pull/7761/commits/7d5e31a82bbf39b9e1a5f0afe5ad9cbf4df9778b
A txid + output # would be more properly called an "Outpoint ID" anyway.
- laanwj merged this on Mar 30, 2016
- laanwj closed this on Mar 30, 2016
- laanwj referenced this in commit 60db51dcb2 on Mar 30, 2016
- codablock referenced this in commit 02ca03b06b on Sep 16, 2017
- codablock referenced this in commit 46105e2604 on Sep 19, 2017
- codablock referenced this in commit 4696bfa618 on Dec 9, 2017
- codablock referenced this in commit 18da34e295 on Dec 19, 2017
- MarcoFalke locked this on Sep 8, 2021
Labels