Split out registration of methods to every module, apart from ‘help’ and ‘stop’ which are implemented in rpcserver.cpp itself.
rpc/server.h by getting rid of the huge cluttered list of function definitions.Continues #7307 for the non-wallet.
void Register*()?
Would it make sense to get rid of the duplicate code in void Register*()?
Maybe. I thought about it, but it’s only a simple loop of four lines, sometimes factoring something so simple out to a function makes things harder to understand, not easier.
Another option would be to export a ‘descriptor structure’ with a name, pointer to the array, and size of the array. E.g. like Linux modules.
But simply having Register* function leaves it up to the module as to how to determine what to register (e.g. there may be optional features enabled on the command line).
Could make it two lines, even, without losing any clarity:
0 for (unsigned int vcidx = 0; vcidx < ARRAYLEN(commands); vcidx++)
1 tableRPC.appendCommand(commands[vcidx].name, &commands[vcidx]);
(will update the one in rpcwallet as well)
pass a pointer to tableRPC to the registration commands
Awesome idea, will do that.
Split out methods to every module, apart from 'help' and 'stop' which
are implemented in rpcserver.cpp itself.
- This makes it easier to add or remove RPC commands - no longer everything that includes
rpcserver.h has to be rebuilt when there's a change there.
- Cleans up `rpc/server.h` by getting rid of the huge cluttered list of function definitions.
- Removes most of the bitcoin-specific code from rpcserver.cpp and .h.
Continues #7307 for the non-wallet.