[0.12] Disable bad-chain alert #7780

pull btcdrak wants to merge 1 commits into bitcoin:0.12 from btcdrak:spurious changing 1 files +11 −4

btcdrak commented at 7:40 PM on March 31, 2016: contributor

Continuous false positives will lead to them being ignored entirely. Better to disable now until this can be fixed more thoroughly in the next release.

Discussed at 2016-03-31 IRC meeting.

Refs: #7568
petertodd commented at 7:42 PM on March 31, 2016: contributor

utACK

Disable bad chain alerts

Continuous false positives lead to them being ignored entirely
so it's better to disable now until this can be fixed more
thoroughly.

869262605f

in src/init.cpp:None in 579107620f outdated

1644 | @@ -1645,10 +1645,10 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
1645 |      StartNode(threadGroup, scheduler);
1646 |  
1647 |      // Monitor the chain, and alert if we get blocks much quicker or slower than expected
1648 | -    int64_t nPowTargetSpacing = Params().GetConsensus().nPowTargetSpacing;
1649 | -    CScheduler::Function f = boost::bind(&PartitionCheck, &IsInitialBlockDownload,
1650 | -                                         boost::ref(cs_main), boost::cref(pindexBestHeader), nPowTargetSpacing);
1651 | -    scheduler.scheduleEvery(f, nPowTargetSpacing);
1652 | +    //int64_t nPowTargetSpacing = Params().GetConsensus().nPowTargetSpacing;

jonasschnelli commented at 7:43 PM on March 31, 2016:

maybe add a comment why we outcomment that part for 0.12.x

btcdrak commented at 7:44 PM on March 31, 2016:

btcdrak commented at 7:51 PM on March 31, 2016:

Done.

btcdrak force-pushed on Mar 31, 2016
petertodd commented at 8:16 PM on March 31, 2016: contributor

utACK new comment
laanwj commented at 9:41 AM on April 1, 2016: member

utACK, nice comment https://github.com/bitcoin/bitcoin/pull/7780/commits/869262605f21973910640676858f4c4a3baa6da8
MarcoFalke commented at 10:00 AM on April 1, 2016: member

utACK but #7568 should be milestoned to 0.13 before this is merged.
laanwj merged this on Apr 1, 2016
laanwj closed this on Apr 1, 2016
laanwj referenced this in commit c5f94f6584 on Apr 1, 2016
laanwj added the label Bug on Apr 1, 2016
btcdrak deleted the branch on Apr 6, 2016
laanwj referenced this in commit 9193a36b17 on Jun 22, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7568 Corrections to bad-chain alert triggering #8241 0.13: Disable bad chain alerts