[Moveonly] Create ui_interface.cpp #7787

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1604-move-ui-helpers changing 6 files +56 −58

MarcoFalke commented at 1:30 PM on April 2, 2016: member

Should be trivial to review, since it's move only besides a missing return true;.
[ui] Move InitError, InitWarning, AmountErrMsg fabbf80f2f
paveljanik commented at 2:51 PM on April 2, 2016: contributor

Concept ACK.

I think that the return true is to have the same prototypes of both Warning and Error functions. Is it worth it?
MarcoFalke commented at 3:05 PM on April 2, 2016: member

Is it worth it?

No, InitError should fail and trigger a shutdown. InitWarning, however, should not trigger a shutdown and continue execution. Thus the return value is not only unused but also misleading.
paveljanik commented at 3:10 PM on April 2, 2016: contributor

@MarcoFalke Of course I agree with you :-)
jonasschnelli commented at 6:01 PM on April 2, 2016: contributor

Concept ACK. Not sure if the function names should contain the Init* part (like InitError() and InitWarning()). From the ui_interface perspective, the error/warning is unrelated to the init process.
jonasschnelli added the label Refactoring on Apr 2, 2016
MarcoFalke commented at 8:53 AM on April 3, 2016: member

the error/warning is unrelated to the init process.

This is a valid point, but I think there is no actual use case for a modal pop up other than in the init process. I'd rather keep the old name, and change it when there is a valid use case for a blocking dialog.
laanwj commented at 12:34 PM on April 3, 2016: member

Concept ACK
MarcoFalke commented at 7:31 PM on April 18, 2016: member

Anything holding this back?
laanwj commented at 1:01 PM on April 19, 2016: member

Nit: the UI interface should be in bitcoin_server.a, not bitcoin_util.a. It should not be used by the other tools, just bitcoind and bitcoin-qt.
Move ui_interface.cpp to libbitcoin_server_a_SOURCES
It is only needed by bitcoind and bitcoin-qt
fa10ce6a6d
MarcoFalke commented at 2:09 PM on April 19, 2016: member

Addressed nit
laanwj merged this on Apr 19, 2016
laanwj closed this on Apr 19, 2016
laanwj referenced this in commit 04a2937357 on Apr 19, 2016
MarcoFalke deleted the branch on Apr 19, 2016
codablock referenced this in commit 63bb0d935c on Sep 16, 2017
codablock referenced this in commit ee11429838 on Sep 19, 2017
codablock referenced this in commit bacc864640 on Dec 20, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels