Use relative paths instead of absolute paths in protoc calls #7788

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20160402_protoc_use_relpath changing 1 files +1 −1
  1. paveljanik commented at 2:43 PM on April 2, 2016: contributor

    When comparing two separate build logs (both being done in its own, different directory), the log line containing protoc shines in the diff:

    $ diff -u 7774.log  master.log | grep protoc
    -/opt/local/bin/protoc --cpp_out=qt --proto_path=/private/tmp/bitcoin-7774/src/qt /private/tmp/bitcoin-7774/src/qt/paymentrequest.proto
    +/opt/local/bin/protoc --cpp_out=qt --proto_path=/private/tmp/bitcoin-master/src/qt /private/tmp/bitcoin-master/src/qt/paymentrequest.proto
    $ 
    

    There is no reason to use absolute paths here.

    After this change, the protoc command line is always

    /opt/local/bin/protoc --cpp_out=qt --proto_path=qt/ qt/paymentrequest.proto
    

    @theuni Please have a look.

  2. laanwj added the label Build system on Apr 3, 2016
  3. paveljanik commented at 9:26 AM on April 4, 2016: contributor

    Travis failure is unrelated to this change.

  4. theuni commented at 5:42 PM on April 4, 2016: member

    I think this should be ok. I suspect it was absolute as part of the initial recursive buildsystem.

    Please make it ... --proto_path=$(<D) $< though, rather than using "dir".

  5. Use relative paths instead of absolute paths 0087f26848
  6. paveljanik force-pushed on Apr 4, 2016
  7. paveljanik commented at 5:58 PM on April 4, 2016: contributor

    Done. Thanks.

  8. paveljanik commented at 6:12 PM on April 4, 2016: contributor

    So after this, the remaining changes/diffs are

    -=== configuring in src/univalue (/tmp/bitcoin-master/src/univalue)
    +=== configuring in src/univalue (/tmp/bitcoin-7788/src/univalue)
    

    for univalue and secp265k1 directories.

  9. theuni commented at 7:03 PM on April 4, 2016: member

    Thanks. ACK.

    Don't think we can do anything about the configure subdirs, the pwd is hard-coded.

  10. paveljanik commented at 9:27 AM on April 5, 2016: contributor

    @theuni yes, I can live with it and ignore such lines.

  11. laanwj commented at 3:38 PM on April 5, 2016: member

    Nice, makes the line a few characters shorter too. utACK 0087f26

  12. laanwj merged this on Apr 5, 2016
  13. laanwj closed this on Apr 5, 2016

  14. laanwj referenced this in commit 4dc1b3a296 on Apr 5, 2016
  15. codablock referenced this in commit d4cd144f30 on Sep 16, 2017
  16. codablock referenced this in commit 2339fe7273 on Sep 19, 2017
  17. codablock referenced this in commit aa5a80cf2d on Dec 9, 2017
  18. codablock referenced this in commit 321e2fb064 on Dec 19, 2017
  19. codablock referenced this in commit 6a515e5e20 on Dec 19, 2017
  20. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-28 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me