[qa] httpbasics: Actually test second connection #7802

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1604-qaTestHttp changing 1 files +9 −9
  1. MarcoFalke commented at 7:37 PM on April 3, 2016: member

    Currently the test will always return Tests successful. :new_moon_with_face:

    (As I am touching this file, I have also marked some byte strings as byte strings explicitly, which is a noop for py2, but helps switching to py3)

  2. [qa] httpbasics: Actually test second connection fa24456d0c
  3. jonasschnelli added the label Tests on Apr 4, 2016
  4. paveljanik commented at 9:22 AM on April 5, 2016: contributor

    It would be easier to review when separated to two commits.

  5. MarcoFalke commented at 10:12 AM on April 5, 2016: member

    @paveljanik The bugfix is visible on two lines: s/out2/out1/g. If you still want me to split, I am happy to do so.

  6. paveljanik commented at 4:51 PM on April 5, 2016: contributor

    No need to do that here (it is very simple fix). I did this for the review myself.

    ACK https://github.com/bitcoin/bitcoin/pull/7802/commits/fa24456d0c4cd0f6571bcf3d8f1f51d8d4242a3e

  7. laanwj merged this on Apr 6, 2016
  8. laanwj closed this on Apr 6, 2016

  9. laanwj referenced this in commit 3bc71e1572 on Apr 6, 2016
  10. MarcoFalke deleted the branch on Apr 6, 2016
  11. MarcoFalke referenced this in commit 3036282c7a on Jun 9, 2016
  12. nomnombtc referenced this in commit 93ea3863cd on Nov 12, 2016
  13. nomnombtc referenced this in commit 0a47580d03 on Nov 12, 2016
  14. nomnombtc referenced this in commit 0fe493c68b on Nov 13, 2016
  15. sickpig referenced this in commit e93f1a9a86 on Nov 14, 2016
  16. zkbot referenced this in commit 1738e6957f on Jul 15, 2017
  17. MarcoFalke locked this on Sep 8, 2021
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me