Refactor script tests #7818

1. 
   sipa commented at 2:16 pm on April 5, 2016: member

   Included is:

   • Fix JSON pretty printing for script test autogeneration (which was broken by univalue, which has different pretty printing).
   • Fix autogeneration of OP_NOP (which generated invalid hex)
   • Some of the included tests were not actually testing what they were intended to test.
   • Merge script_valid and script_invalid into one file (JSON format change)
2. Fix JSON pretty printing in script_tests c7c664191f
3. Fix formatting of NOPs for generated script tests d03e46625a
4. Fix some misconstructed tests

   They claimed to be testing P2SH scripts with non-push scriptSigs, but
   1) they were not enabling P2SH
   2) they have push-only scriptSigs
   
   Fix this, and add a few more related cases.

   269281b7cc
5. Make script_error a mandatory 4th field for script_tests 76da761351
6. Get rid of expect in script_tests as it's implied by scripterror 009b503792
7. Merge script_valid and script_invalid tests dde46d3ae1
8. laanwj added the label Tests on Apr 5, 2016
9. 
   laanwj commented at 3:43 pm on April 5, 2016: member

   utACK https://github.com/bitcoin/bitcoin/pull/7818/commits/dde46d3ae1de18700e089bc1861cf1e18649dc5d
10. 
    dcousens commented at 6:51 am on April 11, 2016: contributor

    concept ACK, once-over utACK dde46d3. I haven’t checked any of the test fixtures themselves to ensure they are as they were (or improved as mentioned).
11. laanwj merged this on Apr 14, 2016
12. laanwj closed this on Apr 14, 2016

    ---

13. laanwj referenced this in commit 3911a0a1b7 on Apr 14, 2016
14. MarcoFalke referenced this in commit 51a55409a0 on May 4, 2016
15. MarcoFalke referenced this in commit e3a9ce9c94 on May 4, 2016
16. nomnombtc referenced this in commit 03bee8d04e on Nov 12, 2016
17. nomnombtc referenced this in commit 62341e597a on Nov 12, 2016
18. nomnombtc referenced this in commit fdaa711d58 on Nov 13, 2016
19. sickpig referenced this in commit 58f48e3bbd on Nov 14, 2016
20. zkbot referenced this in commit be459619a8 on Mar 5, 2021
21. zkbot referenced this in commit 78de0cdf46 on Apr 15, 2021
22. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa laanwj dcousens

Labels
Tests