Prevent multiple calls to ExtractDestination #7825

pull pedrobranco wants to merge 1 commits into bitcoin:master from uphold:enhancement/prevent-multiple-calls-extractdestination changing 1 files +19 −22

pedrobranco commented at 11:59 AM on April 6, 2016: contributor

Trivial performance improvement.

It consists in preventing multiple calls to ExtractDestination in rpc call listunspent. For an large UTXO set the improvement are more notable.

This PR moves the computation of multiple ExtractDestination to a single call, and also reorganizes the code of building the JSON result of each UTXO.
laanwj added the label Wallet on Apr 6, 2016
pedrobranco force-pushed on Apr 6, 2016
dcousens commented at 3:16 AM on April 7, 2016: contributor

utACK 4a7c2f4
laanwj commented at 7:51 AM on April 9, 2016: member

Concept ACK
paveljanik commented at 10:01 PM on April 22, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/7825/commits/4a7c2f4c5a3c9c68bf7f50670f825fcbf1769dbb

To get more people looking at this, please provide some interesting numbers ;-))
pedrobranco commented at 5:29 PM on May 3, 2016: contributor

The performance improvement isn't much significant on typical wallets. The main advantage is the reuse of the function ExtractDestination( and the organization of listunspent call.
NicolasDorier commented at 6:05 AM on May 5, 2016: contributor
I would add this condition so it is equivalent to before:
```
if(!fValidAddress && setAddress.size() > 0)
    continue;
```
pedrobranco commented at 9:18 AM on May 5, 2016: contributor

@NicolasDorier You are right. Will fix.
pedrobranco force-pushed on May 5, 2016
pedrobranco force-pushed on May 5, 2016
NicolasDorier commented at 8:44 PM on May 5, 2016: contributor

utACK 83153e6 (nit: redeemScript does not appear in the help message.)
pedrobranco force-pushed on May 6, 2016
Prevent multiple calls to ExtractDestination 0bf6f30262
pedrobranco force-pushed on May 6, 2016
sipa commented at 3:10 PM on June 2, 2016: member

utACK 0bf6f302626497184a26b88c61fe6af1741e2a44
jonasschnelli commented at 7:45 PM on June 2, 2016: contributor

Core-Review utACK 0bf6f302626497184a26b88c61fe6af1741e2a44
sipa merged this on Jun 2, 2016
sipa closed this on Jun 2, 2016
sipa referenced this in commit f972b04d63 on Jun 2, 2016
pedrobranco deleted the branch on Jun 3, 2016
codablock referenced this in commit 4e38bf7b05 on Sep 16, 2017
codablock referenced this in commit 6a567019ea on Sep 19, 2017
codablock referenced this in commit df14a7f009 on Dec 22, 2017
zkbot referenced this in commit 2c1f65d6e2 on Apr 23, 2018
zkbot referenced this in commit 1c2f24793b on Apr 24, 2018
zkbot referenced this in commit d5b558ba5b on Apr 25, 2018
zkbot referenced this in commit 962ba99b36 on Apr 25, 2018
zkbot referenced this in commit e84f02af8b on May 1, 2018
zkbot referenced this in commit bcd65519ca on May 1, 2018
zkbot referenced this in commit 90304c4214 on May 1, 2018
andvgal referenced this in commit 5d1e68390c on Jan 6, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels