Expose information on whether transaction relayed is enabled in getnetwork #7841

pull ghost wants to merge 22 commits into bitcoin:master from changing 2 files +16 −11
  1. ghost commented at 2:17 pm on April 8, 2016: none

    adding CNode::fRelayTxes to getnetworkinfo under the name of localrelay (bool)

    updated pull #7839 #7771

  2. Expose information on whether transaction relayed is enabled in getnetworkinfo 
    adding CNode::fRelayTxes to getnetworkinfo under the name of localrelay (bool)
    ea4c315f82
  3. Update net.h 016818fd70
  4. Update net.cpp 
    adding GetfRelayTxes
    8a70557b8a
  5. Update net.h 4785e67e1c
  6. ghost commented at 2:29 pm on April 8, 2016: none
    a new fix has been applyed to this code
  7. sipa commented at 2:30 pm on April 8, 2016: member
    @dragongem45 If you find more things to fix in the future, you can just force push to the github branch associated with it, you don’t need to close and open a new pull request.
  8. ghost commented at 2:34 pm on April 8, 2016: none
    is there a way to restart travis-ci biulds
  9. sipa commented at 2:36 pm on April 8, 2016: member
    @dragongem45 Yes, by pushing a new commit.
  10. ghost commented at 2:40 pm on April 8, 2016: none
    do you have any ideas on what i am doing wrong
  11. sipa commented at 2:42 pm on April 8, 2016: member

    See https://travis-ci.org/bitcoin/bitcoin/jobs/121714563

    0In file included from main.h:16:0,
1                 from checkpoints.cpp:9:
2net.h: In static member function ‘static bool CNode::GetfRelayTxes()’:
3net.h:360:10: error: invalid use of member ‘CNode::fRelayTxes’ in static member function
4net.h:362:16: error: from this location

    Can you try compiling your own code before submitting a patch?

  12. Update net.h a4edebbcc7
  13. ghost commented at 2:45 pm on April 8, 2016: none
    ok i wil form this message here thanks for the tips
  14. Update net.cpp 5c3f809e64
  15. Update net.cpp bc022fbd88
  16. Update net.h f91fbd145f
  17. Update net.cpp 97c507f225
  18. Update net.h 7ea282a601
  19. Update net.cpp 1d5418b7e7
  20. Update net.cpp e540d7ab47
  21. Update net.cpp 25bcef725d
  22. Update net.cpp d567ecfd4d
  23. Update net.h adfb1aed5d
  24. MarcoFalke commented at 5:27 pm on April 8, 2016: member
    @dragongem45 Please build and test your changes locally. Also make sure to squash the commits using git locally. If there are any issues we can help you in the IRC.
  25. ghost commented at 5:31 pm on April 8, 2016: none
    sorry its a part of my IDE i’m going to disable it. just today it seems like all my code breaks
  26. Update net.cpp 6d6d09155b
  27. Update net.cpp 26982111be
  28. Update net.cpp 763f0dd9b5
  29. Update net.cpp ab19479204
  30. ghost commented at 8:02 pm on April 8, 2016: none
    compile worked. now there is a python test error
  31. Update net.cpp 1f815c879e
  32. sipa commented at 8:18 pm on April 8, 2016: member
    It seems you’re turning getnetworkinfo into something that returns information about all peers. That’s not correct. fRelayTxs is a per-peer variable, so if you want to expose it, it will go in getpeerinfo which lists information over all peers.
  33. Update net.cpp 97fcf6dae1
  34. Update net.cpp 4543339db9
  35. MarcoFalke commented at 11:24 am on April 9, 2016: member

    @dragongem45 Please squash your commits:

    0git clone https://github.com/dragongem45/bitcoinclassic.git bitcoin
1cd bitcoin
2git fetch --all
3git checkout patch-2
4git rebase --interactive ea4c315~
5[Select "f" for all lines but the first]
6git push origin patch-2 -f
  36. sipa commented at 1:59 pm on April 12, 2016: member
    The relaytxes field in getnetworkinfo now reports whether we have at least one peer which has the fRelayTxs flag set. Wouldn’t it be more logical to put it in getpeerinfo, where it gets reported for every peer individually?
  37. laanwj commented at 8:28 am on April 19, 2016: member

    The relaytxes field in getnetworkinfo now reports whether we have at least one peer which has the fRelayTxs flag set. Wouldn’t it be more logical to put it in getpeerinfo, where it gets reported for every peer individually?

    I think it’s not implemented correctly. The original idea behind exposing this on the interface is so that applications know whether we relay transactions. So what value of relaytxes we send in our version message (-blocksonly would set this to false, for example).

    Per-peer information could be useful too, but that’s orthogonal.

  38. laanwj added the label RPC/REST/ZMQ on Apr 19, 2016
  39. in src/net.h: in 4543339db9 
    768@@ -769,8 +769,6 @@ class CNode
769     static uint64_t GetMaxOutboundTimeLeftInCycle();
770 };
771 
772-
773-
    MarcoFalke commented at 9:10 am on April 19, 2016:

    @dragongem45 Are you still working on this?

    Please remove this diff and squash your commits.

  40. sipa commented at 5:15 am on April 21, 2016: member
    Agree with @laanwj
  41. laanwj referenced this in commit 12dde910d3 on May 12, 2016
  42. laanwj referenced this in commit 1ab1dc3140 on May 12, 2016
  43. laanwj commented at 12:27 pm on May 12, 2016: member
    Closing in favor of #8049
  44. laanwj closed this on May 12, 2016
  45. OlegGirko referenced this in commit 0dc5f378b4 on Jun 26, 2017
  46. OlegGirko referenced this in commit 8ad72871b9 on Jun 29, 2017
  47. OlegGirko referenced this in commit 2386aa0f31 on Jun 29, 2017
  48. OlegGirko referenced this in commit b65b2acb60 on Jun 29, 2017
  49. OlegGirko referenced this in commit c730586a7d on Jun 30, 2017
  50. OlegGirko referenced this in commit dd520e4393 on Jul 2, 2017
  51. OlegGirko referenced this in commit cb0773a268 on Jul 3, 2017
  52. OlegGirko referenced this in commit 0ee087cd1a on Jul 4, 2017
  53. OlegGirko referenced this in commit 51faf3a827 on Jul 4, 2017
  54. OlegGirko referenced this in commit 4e5825a0aa on Jul 5, 2017
  55. OlegGirko referenced this in commit 6e71d4a092 on Jul 5, 2017
  56. OlegGirko referenced this in commit c9f9551936 on Jul 5, 2017
  57. OlegGirko referenced this in commit 6c00f15c3f on Jul 9, 2017
  58. OlegGirko referenced this in commit fa9cf940a2 on Jul 10, 2017
  59. OlegGirko referenced this in commit fd4cfd5146 on Jul 11, 2017
  60. OlegGirko referenced this in commit b3fd0502b0 on Jul 11, 2017
  61. OlegGirko referenced this in commit a2669a5dfe on Jul 12, 2017
  62. OlegGirko referenced this in commit 70b206551a on Jul 13, 2017
  63. OlegGirko referenced this in commit 1eadd5abce on Jul 13, 2017
  64. OlegGirko referenced this in commit 955bfd4650 on Jul 14, 2017
  65. OlegGirko referenced this in commit 15bf253367 on Jul 14, 2017
  66. OlegGirko referenced this in commit b08555b005 on Jul 16, 2017
  67. OlegGirko referenced this in commit 230b5d68f6 on Jul 16, 2017
  68. OlegGirko referenced this in commit 094d5baf84 on Jul 17, 2017
  69. OlegGirko referenced this in commit 6346dbd18f on Jul 17, 2017
  70. OlegGirko referenced this in commit 9bb00553f2 on Jul 18, 2017
  71. UdjinM6 referenced this in commit 82851b439c on Jul 21, 2017
  72. lateminer referenced this in commit d6c228b173 on Jan 5, 2018
  73. MarcoFalke locked this on Sep 8, 2021


ghost sipa MarcoFalke laanwj

Labels
RPC/REST/ZMQ

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 10:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me