The current tests for varint only check that serialization-deserialization is a roundtrip. That is a useful test, but it is also good to check for some exact bit patterns, to prevent a code change that changes the serialization format from going undetected (or a similar incompatibility between platforms).
As the varint functions are templated, also check with different types.
I wrote this test in the course of diagnosing #7848 and everything turned out to be good, but it makes sense anyhow.
The current tests for varint only check that
serialization-deserialization is a roundtrip. That is a useful test, but
it is also good to check for some exact bit patterns, to prevent a code
change that changes the serialization format from going undetected.
As the varint functions are templated, also check with different types.
Indeed, makes sense. Concept ACK.
ACK 4521f005a1e61969f21b91a7e8eef5a5cdfdd191. More tests are always good.
utACK 4521f005a1e61969f21b91a7e8eef5a5cdfdd191
