Qa: some code style reflected for pep8 #7864

pull RyanKung wants to merge 2 commits into bitcoin:master from RyanKung:dev/rk changing 5 files +183 −168

RyanKung commented at 11:42 AM on April 12, 2016: none

I just read the test code and reflected it to https://www.python.org/dev/peps/pep-0008/ code style. There is partial of them, and if this pull request be accepted, I will continue to reflect all of them done.

(I'm not a native English speaker, and sorry for my bad English)
for pep8 8bb3631641
code style reflact (pep8) c36197e8ff

in qa/pull-tester/rpc-tests.py:None in c36197e8ff

  53 |          import zmq
  54 |      except ImportError:
  55 | -        print("WARNING: \"import zmq\" failed. Setting ENABLE_ZMQ=0. " \
  56 | -            "To run zmq tests, see dependency info in /qa/README.md.")
  57 | -        ENABLE_ZMQ=0
  58 | +        print('''WARNING: \"import zmq\" failed. Setting ENABLE_ZMQ=0. "

MarcoFalke commented at 11:52 AM on April 12, 2016:

I don't think they are equivalent.

RyanKung commented at 11:59 AM on April 12, 2016:

@MarcoFalke yes, you are right, review & fixing

MarcoFalke commented at 11:53 AM on April 12, 2016: member

I appreciate that the code is being cleaned up but some of the patches will conflict with my pull requests to refactor to python3, so I'd prefer to hold this back until the switch is done.
RyanKung commented at 12:00 PM on April 12, 2016: none

@MarcoFalke Ok
RyanKung closed this on Apr 12, 2016
bitcoin locked this on Sep 8, 2021

Contributors

RyanKung

MarcoFalke