[test] bctest.py: Revert faa41ee #7878

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1604-bctestPy changing 1 files +1 −2

MarcoFalke commented at 6:01 PM on April 14, 2016: member
Fixes #7853 (comment)

Rationale:
- The type of input must be bytes or, if universal_newlines was True, a string. [1]
- universal_newlines is set to True [2]
So this pull reverts to the old behavior of using strings on py3 as well as on py2. No changes to this file were necessary, as it is already compatible. (At this point, I am not sure why I changed this in the first place)

Edit: The reason this went unnoticed on travis was that travis still runs py2.7 but other systems will choose python3 if available since 18f05c765c800126b74a6d5b7f33cef7c9aae1b7
[test] bctest.py: Revert faa41ee fa7abe0a00
mruddy commented at 7:36 PM on April 14, 2016: contributor

ACK I researched this a little before and came to the same conclusion about universal_newlines. That's what confused me about your initial change. Reassuring that we both came to the same conclusion now. Thanks for the quick fix!
paveljanik commented at 7:47 PM on April 14, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/7878/commits/fa7abe0a00464e6aa88d55c63dba40878bbe5b79
laanwj added the label Tests on Apr 15, 2016
laanwj merged this on Apr 15, 2016
laanwj closed this on Apr 15, 2016
laanwj referenced this in commit 53adc8310d on Apr 15, 2016
laanwj commented at 5:59 AM on April 15, 2016: member

tACK https://github.com/bitcoin/bitcoin/pull/7878/commits/fa7abe0a00464e6aa88d55c63dba40878bbe5b79
MarcoFalke deleted the branch on Apr 15, 2016
codablock referenced this in commit ff9da21a94 on Sep 16, 2017
codablock referenced this in commit 42e244aeba on Sep 19, 2017
codablock referenced this in commit 7080c27dd6 on Dec 20, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7853 [qa] py2: Unfiddle strings into bytes explicitly #7893 bitcoin-util-test.py fails with python3.2