QA test fix: ensure unique coinbase transactions #7885

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:rpctest_unique_coinbases changing 1 files +4 −2
  1. gavinandresen commented at 7:11 PM on April 15, 2016: contributor

    If given the same height and public key, blocktools.py create_coinbase would generate the same coinbase transaction-- bad if you're writing a test for forking scenarios where you want to generate two different blocks at the same block height.

    This adds a unique counter to create_coinbase, so every call returns a unique transaction.

    Tested by running all of the rpc-tests that use create_coinbase (and ran correctly before this pull request -- bip68-sequence.py fails when compiled -DDEBUG_LOCKORDER).

  2. QA test fix: ensure unique coinbase transactions dadfe1682d
  3. gavinandresen added the label Tests on Apr 15, 2016
  4. gavinandresen commented at 7:27 PM on April 15, 2016: contributor

    Bah I missed a test: bip65-cltv-p2p.py is failing with bad-cb-height. Will re-open this after I fix it.

  5. gavinandresen closed this on Apr 15, 2016

  6. MarcoFalke locked this on Sep 8, 2021
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me