QA test fix: ensure unique coinbase transactions #7886

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:rpctest_unique_coinbases changing 1 files +4 −2
  1. gavinandresen commented at 7:44 PM on April 15, 2016: contributor

    Apologies for the pull request spam, I can't re-open the previous version of this:

    If given the same height and public key, blocktools.py create_coinbase would generate the same coinbase transaction-- bad if you're writing a test for forking scenarios where you want to generate two different blocks at the same block height.

    This adds a unique counter to create_coinbase, so every call returns a unique transaction.

    Tested by running all of the rpc-tests that use create_coinbase (and ran correctly before this pull request -- bip68-sequence.py fails when compiled -DDEBUG_LOCKORDER).

  2. QA test fix: ensure unique coinbase transactions 8f17c3b03f
  3. jonasschnelli added the label Tests on Apr 16, 2016
  4. laanwj closed this on Aug 3, 2016

  5. laanwj commented at 10:24 AM on August 3, 2016: member

    Closing this - There is no point in merging this as-is. if anyone needs this functionality for a test they are writing, they can cherry-pick this as well.

  6. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me