txdb: Fix assert crash in new UTXO set cursor #7904

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_04_fix_utxo_iterator changing 1 files +1 −5

laanwj commented at 10:10 AM on April 18, 2016: member

Remove the mistaken assumption that GetKey returning false signifies an internal database issue. It will return false when the key cannot be deserialized into the (char,uint256) stanza, which indicates that the cursor has reached a different kind of key.

Fixes bug #7890 introduced in #7756.

txdb: Fix assert crash in new UTXO set cursor

Remove the mistaken assumption that GetKey returning false signifies
an internal database issue. It will return false when the key cannot
be deserialized into the (char,uint256) stanza, which indicates
that the cursor has reached a different kind of key.

Fixes bug #7890 introduced in #7756.

a3310b4d48

laanwj added the label UTXO Db and Indexes on Apr 18, 2016
sipa commented at 10:49 AM on April 18, 2016: member

utACK a3310b4d485b1510c240f1db882530590b6fd7c9
paveljanik commented at 12:04 PM on April 18, 2016: contributor
tested ACK https://github.com/bitcoin/bitcoin/pull/7904/commits/a3310b4d485b1510c240f1db882530590b6fd7c9

Current master aborts at the end of gettxoutsetinfo:
```
Assertion failed: (ok), function Next, file txdb.cpp, line 139.
Abort trap: 6
```
With this change, the command finished without abort.

Thanks!
laanwj merged this on Apr 19, 2016
laanwj closed this on Apr 19, 2016
laanwj referenced this in commit fc9e3346e6 on Apr 19, 2016
codablock referenced this in commit 8602b99318 on Sep 16, 2017
codablock referenced this in commit b64cd1ea96 on Sep 19, 2017
codablock referenced this in commit 9b0bc05565 on Sep 27, 2017
codablock referenced this in commit 89fcb5dc5f on Oct 12, 2017
codablock referenced this in commit 17f2ea5d73 on Oct 19, 2017
UdjinM6 referenced this in commit e1885ea7ad on Nov 8, 2017
str4d referenced this in commit 4f3d6245d5 on Jan 27, 2018
str4d referenced this in commit 9b1958bf06 on Mar 9, 2018
str4d referenced this in commit 18752ec0ce on Mar 12, 2018
str4d referenced this in commit 8b4e86b6d3 on Mar 15, 2018
str4d referenced this in commit 9160285eea on Mar 30, 2018
str4d referenced this in commit c602b06475 on Apr 4, 2018
str4d referenced this in commit 06f21492d5 on May 31, 2018
str4d referenced this in commit 9d3c1a7098 on Oct 24, 2018
str4d referenced this in commit 06f3023ac1 on Jan 4, 2019
str4d referenced this in commit 2705fea323 on Mar 14, 2019
str4d referenced this in commit 9e893790c3 on Apr 2, 2019
str4d referenced this in commit ffc99bbf49 on Apr 5, 2019
str4d referenced this in commit 3647f0a7b1 on May 23, 2019
milesmanley referenced this in commit aad9246f47 on Jun 22, 2019
blondfrogs referenced this in commit 8156c70d30 on Jun 28, 2019
milesmanley referenced this in commit 6ffd55e6b6 on Aug 27, 2019
TheTrunk referenced this in commit 0d20c51843 on Aug 27, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7756 Add cursor to iterate over utxo set, use this in `gettxoutsetinfo`#7890 master: `gettxoutsetinfo` -> crash