Explicitly pass CChainParams& to DisconnectTip() #7916

pull hmel wants to merge 3 commits into bitcoin:master from hmel:global-params-cleanup changing 3 files +17 −17
  1. hmel commented at 1:22 PM on April 20, 2016: contributor

    Continue work on #7829 started by @jtimon Pass CChainParams& to UpdateTip(), DisconnectTip(), InvalidateBlock() and ConnectBlock(), and remove global Params() call.

  2. Globals: Explicitly pass const CChainParams& to UpdateTip() 764d237772
  3. Pass CChainParams to DisconnectTip() d0a6353dec
  4. jtimon commented at 1:32 PM on April 20, 2016: contributor

    utACK

  5. jonasschnelli added the label Refactoring on Apr 20, 2016
  6. laanwj commented at 1:53 PM on April 20, 2016: member

    utACK https://github.com/bitcoin/bitcoin/pull/7916/commits/d0a6353dec48f365c38de3c76b42f67eda737ed5 utACK 176869f

  7. hmel commented at 1:58 PM on April 20, 2016: contributor

    I have a patch for ConnectBlock() which is also a few lines. Should I push it here as well?

  8. Explicitly pass CChainParams to ConnectBlock 176869f9b3
  9. jtimon commented at 2:08 PM on April 20, 2016: contributor

    Since ConnectBlock() is trivial enough and the PR is still recent, I would say we're still on time to slightly increase the scope of this PR with an additional commit. @laanwj thoughts?

  10. sipa commented at 2:15 PM on April 20, 2016: member

    Concept ACK on adding ConnectBlock()

  11. laanwj commented at 2:30 PM on April 20, 2016: member

    @jtimon fine with me. As I said in #7876, I prefer bundling changes that are easy to review like this one.

  12. jtimon commented at 7:19 PM on April 20, 2016: contributor

    re-utACK (after adding 176869f ).

  13. dcousens commented at 3:40 AM on April 21, 2016: contributor

    utACK 176869f

  14. laanwj merged this on Apr 21, 2016
  15. laanwj closed this on Apr 21, 2016
  16. laanwj referenced this in commit 3689ac4634 on Apr 21, 2016
  17. hmel deleted the branch on Apr 21, 2016
  18. codablock referenced this in commit 44271f6145 on Sep 16, 2017
  19. codablock referenced this in commit c5b44f4c88 on Sep 19, 2017
  20. codablock referenced this in commit 5cf744532b on Dec 20, 2017
  21. zkbot referenced this in commit 6dcc7dd6ce on Mar 9, 2018
  22. zkbot referenced this in commit b094b02c0b on Mar 10, 2018
  23. zkbot referenced this in commit 59ef0e4c9c on Mar 12, 2018
  24. zkbot referenced this in commit 6dfd4baa1a on Mar 12, 2018
  25. zkbot referenced this in commit 05132fdca8 on Apr 6, 2018
  26. zkbot referenced this in commit 5fefc451a7 on Apr 13, 2018
  27. zkbot referenced this in commit 4c91fbf1c7 on May 31, 2018
  28. zkbot referenced this in commit 82d64f57c9 on Oct 24, 2018
  29. zkbot referenced this in commit 971f37e510 on Oct 25, 2018
  30. zkbot referenced this in commit 5b8b057c96 on Apr 5, 2019
  31. zkbot referenced this in commit a53fd12544 on Apr 9, 2019
  32. zkbot referenced this in commit fcf551eaaf on May 24, 2019
  33. zkbot referenced this in commit e25cb39033 on May 24, 2019
  34. zkbot referenced this in commit 3d37ebe9d8 on May 28, 2019
  35. MarcoFalke locked this on Sep 8, 2021
Contributors
hmeljtimonlaanwjsipadcousens
Labels
Refactoring
Linked (view graph)
#7829 Globals: TODO: Experiment: Kill "Params()"
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me