[contrib] verify-commits: Add MarcoFalke fingerprint #7921

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1604-contribMFfingerp changing 1 files +1 −0

MarcoFalke commented at 1:35 PM on April 21, 2016: member

No description provided.
[contrib] verify-commits: Add MarcoFalke fingerprint fa24329334

jonasschnelli commented at 1:39 PM on April 21, 2016: contributor

Hmm... seems not to match with your gitian key.

pub   4096R/F4316B9B 2015-12-14
      Key fingerprint = B8B3 F1C0 E58C 15DB 6A81  D30C 3648 A882 F431 6B9B
uid                  Marco Falke <falke.marco@gmail.com>
sub   2048R/E50FE137 2015-12-14 [expires: 2016-06-11]
sub   2048R/F6B61B9A 2015-12-14 [expires: 2016-06-11]

laanwj commented at 1:40 PM on April 21, 2016: member

Matches with first subkey though:

pub   4096R/F4316B9B 2015-12-14
      Key fingerprint = B8B3 F1C0 E58C 15DB 6A81  D30C 3648 A882 F431 6B9B
uid                  Marco Falke <falke.marco@gmail.com>
sub   2048R/E50FE137 2015-12-14 [expires: 2016-06-11]
      Key fingerprint = FE09 B823 E6D8 3A3B C798  3EAA 2D7F 2372 E50F E137
sub   2048R/F6B61B9A 2015-12-14 [expires: 2016-06-11]
      Key fingerprint = B6C7 2B4A 758C C29B 483E  82C7 6DF9 EDF1 F6B6 1B9A

The important thing is that it matches the key used for signing merges, so if you use the subkey, that one should be in here.

laanwj added the label Dev Scripts on Apr 21, 2016
jonasschnelli commented at 1:44 PM on April 21, 2016: contributor

Right. It matches with the first subkey. My fault!
MarcoFalke commented at 1:45 PM on April 21, 2016: member

You need to pass --fingerprint twice.
sipa commented at 1:49 PM on April 21, 2016: member

You need to pass --fingerprint twice.

Today I learned!

MarcoFalke commented at 1:55 PM on April 21, 2016: member

The important thing is that it matches the key used for signing merges, so if you use the subkey, that one should be in here.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I will use the subkeys for everyday signing (gitian results, emails, merge
commits, or this very message I am typing right now, etc) and decryption. The
root key is used to sign other keys or extend the lifetime of the subkeys.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXGNssAAoJEC1/I3LlD+E3BHEH/jIBfm5XiLFH8JZX4RN4j/uS
IsZnJnPlZVZsqrmTFQWR4OYjSfeyGtH3ICxVdbEgkg+T8f709KGi+sJKG3H823W7
0eGPdqYZFmb7m/A5odJ7ovTSuvTWsU/1MTIvWOhD3+faLEnuNngInaF2H6bpqe7Y
EdykKpgJwvttbV4cRLPY/sT4ZWvXKSrOn+67dtGB9KwNcc8hnNFGVX9h7Vc8MWL1
zWcGwpKfU4oPLr4UfIAMQx9NGboaDw0rWyM5dki3hJCvy17CGzk3+Ae/I8J7jRGk
1taZwIhtROtMFcDicr629KCA5oGUqjtbXIfmu5cu+Zy5uoL3aC/Q/XukGyC3Gso=
=1Mrt
-----END PGP SIGNATURE-----

laanwj commented at 2:03 PM on April 21, 2016: member

ACK https://github.com/bitcoin/bitcoin/pull/7921/commits/fa243293343eb964bfee5b91cc52b91f16232ab6
jonasschnelli commented at 2:05 PM on April 21, 2016: contributor

ACK fa243293343eb964bfee5b91cc52b91f16232ab6
laanwj commented at 2:33 PM on April 21, 2016: member

Travis failure is unrelated (another timeout...)
laanwj merged this on Apr 21, 2016
laanwj closed this on Apr 21, 2016
laanwj referenced this in commit 78d61aab23 on Apr 21, 2016
MarcoFalke deleted the branch on Apr 21, 2016
codablock referenced this in commit 847105b6d2 on Sep 16, 2017
codablock referenced this in commit 09e9b4fe40 on Sep 19, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels