SetString seems to be passing the length of the wrong variable to memory_cleanse, resulting in the last byte of the temporary buffer not being securely erased.
CBase58Data::SetString: cleanse the full vector #7922
pull kazcw wants to merge 1 commits into bitcoin:master from kazcw:cleanse-fully changing 1 files +1 −1-
kazcw commented at 1:33 AM on April 22, 2016: contributor
-
57704499be
CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to memory_cleanse, resulting in the last byte of the temporary buffer not being securely erased.
-
paveljanik commented at 6:03 AM on April 22, 2016: contributor
-
laanwj commented at 6:19 AM on April 22, 2016: member
This one is sneaky, good catch. utACK https://github.com/bitcoin/bitcoin/pull/7922/commits/57704499be948c640c789c7fc11ed1abf8a681bd
- laanwj added the label Utils and libraries on Apr 22, 2016
-
jonasschnelli commented at 6:55 AM on April 22, 2016: contributor
- laanwj added the label Needs backport on Apr 22, 2016
- laanwj merged this on Apr 22, 2016
- laanwj closed this on Apr 22, 2016
- laanwj referenced this in commit 90653bc91d on Apr 22, 2016
- MarcoFalke referenced this in commit 86b9737162 on Apr 25, 2016
- MarcoFalke referenced this in commit 5978664584 on Apr 27, 2016
- kazcw deleted the branch on Apr 29, 2016
- MarcoFalke referenced this in commit c3d1bc33b5 on Jun 4, 2016
-
MarcoFalke commented at 10:58 AM on June 9, 2016: member
Backported as part of #7938. Removing label 'Needs backport'.
- MarcoFalke removed the label Needs backport on Jun 9, 2016
- thokon00 referenced this in commit a6cab88e1a on Jun 28, 2016
- nomnombtc referenced this in commit b3691fa398 on Nov 12, 2016
- nomnombtc referenced this in commit 7dccf155a2 on Nov 12, 2016
- nomnombtc referenced this in commit 977a121f97 on Nov 13, 2016
- sickpig referenced this in commit 2eeec1a501 on Nov 14, 2016
- zkbot referenced this in commit 2c1f65d6e2 on Apr 23, 2018
- zkbot referenced this in commit 1c2f24793b on Apr 24, 2018
- zkbot referenced this in commit d5b558ba5b on Apr 25, 2018
- zkbot referenced this in commit 962ba99b36 on Apr 25, 2018
- zkbot referenced this in commit e84f02af8b on May 1, 2018
- zkbot referenced this in commit bcd65519ca on May 1, 2018
- zkbot referenced this in commit 90304c4214 on May 1, 2018
- random-zebra referenced this in commit 961e2d2a70 on Jun 27, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels