qt: Fix out-of-tree GUI builds #7925

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_04_qt_out_of_tree_build changing 1 files +2 −2

laanwj commented at 7:23 AM on April 22, 2016: member
Without this patch:
- When I compile the GUI from the bitcoin directory itself, it works as expected.
- When I build the GUI in an out-of-tree build, I cannot get it to select tabs. When I click, say the "Receive" tab nothing happens, the button selects but it doesn't switch the page. The rest - even the debug window - seems to work.
See full discussion here: #7911 (comment)

This turned out to be caused by a mismatch in the arguments to moc, preventing it from finding bitcoin-config.h. Fix this by passing $(DEFAULT_INCLUDES) to it, which gets set to the appropriate path by autoconf itself.

qt: Fix out-of-tree GUI builds

Without this patch:

- When I compile the GUI from the bitcoin directory itself, it works as
  expected.

- When I build the GUI in an out-of-tree build, I cannot get it to
  select tabs. When I click, say the "Receive" tab nothing happens,
  the button selects but it doesn't switch the page. The rest - even
  the debug window - seems to work.

See full discussion here:
https://github.com/bitcoin/bitcoin/pull/7911#issuecomment-212413442

This turned out to be caused by a mismatch in the arguments to moc,
preventing it from finding `bitcoin-config.h`. Fix this by passing
`$(DEFAULT_INCLUDES)` to it, which gets set to the appropriate
path by autoconf itself.

f59dceb44f

laanwj added the label GUI on Apr 22, 2016
jonasschnelli commented at 7:24 AM on April 22, 2016: contributor

Thanks. utACK f59dceb44f9bcfe1447b2dcca7483ed806cab22a
laanwj merged this on Apr 22, 2016
laanwj closed this on Apr 22, 2016
laanwj referenced this in commit f604bf6321 on Apr 22, 2016
theuni commented at 5:19 AM on April 23, 2016: member

Thanks!
jmcorgan referenced this in commit 932aedd99a on Jun 8, 2016
laanwj referenced this in commit 080457c4ee on Jun 28, 2016
thokon00 referenced this in commit d6843f76e4 on Jun 28, 2016
nomnombtc referenced this in commit 232becc789 on Nov 12, 2016
nomnombtc referenced this in commit 488be94c7c on Nov 12, 2016
nomnombtc referenced this in commit 8106fe0abc on Nov 13, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7911 leveldb: integrate leveldb into our buildsystem