Previously disk corruption would cause an assert instead of an exception.
This has not been extensively reviewed.
CDataStream::ignore Throw exception instead of assert on negative nSize. #7936
pull pstratem wants to merge 1 commits into bitcoin:master from pstratem:2016-04-24-cdatastream-ignore changing 1 files +3 −1-
pstratem commented at 7:11 AM on April 25, 2016: contributor
- jonasschnelli added the label Refactoring on Apr 25, 2016
- pstratem force-pushed on Apr 25, 2016
-
2ed0ca42f7
CDataStream::ignore Throw exception instead of assert on negative nSize.
Previously disk corruption would cause an assert instead of an exception.
-
laanwj commented at 8:45 AM on April 25, 2016: member
Concept ACK.
How do the call-sites of this function cope with this exception? I suppose this is only used in reindexing?
-
-
pstratem commented at 12:17 PM on April 25, 2016: contributor
CDataStream::ignore -> CScriptCompressor::Unserialize -> CTxOutCompressor::SerializationOp
CCoins::GetSerializeSize,Serialize,Unserialize CTxInUndo::GetSerializeSize,Serialize,Unserialize
Still working on what calls those...
- pstratem renamed this:
CDataStream::ignore Throw exception instead of assert on negative nSize.
[WIP] CDataStream::ignore Throw exception instead of assert on negative nSize.
on Apr 25, 2016 - pstratem renamed this:
[WIP] CDataStream::ignore Throw exception instead of assert on negative nSize.
CDataStream::ignore Throw exception instead of assert on negative nSize.
on Apr 25, 2016 -
-
-
- laanwj closed this on Apr 26, 2016
- MarcoFalke locked this on Sep 8, 2021
Labels