Should be safe to revert now, I assume?
Edit: Initially this timed out, but it seems this does no longer timeout as of today...
Good to merge?
Revert "travis: temporarily disable qt to avoid timeouts" #7945
pull MarcoFalke wants to merge 4 commits into bitcoin:master from MarcoFalke:Mf1604-travisQtCache changing 9 files +569 −6-
MarcoFalke commented at 11:26 AM on April 26, 2016: member
- MarcoFalke added the label Build system on Apr 26, 2016
- laanwj assigned theuni on Apr 26, 2016
-
67969af09f
build: Enable C++11 build, require C++11 compiler
Implements #6211.
-
fade8912b2
Revert "travis: temporarily disable qt to avoid timeouts"
This reverts commit a33b7c9cb545985771d074748c0e368ca2d06702.
- MarcoFalke force-pushed on Apr 27, 2016
-
depends: use c++11 a398549b3b
- MarcoFalke force-pushed on Apr 27, 2016
-
-
theuni commented at 5:24 PM on April 27, 2016: member
Not yet. It's building quickly now because it's been incrementally cached. The issue will be fresh builds with no cache (#7165 as an example, which will essentially be a complete rebuild).
I think we should work on speeding up tests first. I played around with parallelizing the rpc tests yesterday with reasonable success.
Additionally, https://github.com/travis-ci/travis-build/pull/706 will buy us a few extra minutes, as we'll be able to switched to the stripped down image that should startup quicker. @MarcoFalke to see where we stand, you could try merging #7165 in here and seeing how long it takes.
-
WIP: Merge commit 'a398549' into Mf1604-travisQtCache 8d5b55f125
-
laanwj commented at 9:03 AM on April 28, 2016: member
Maybe we can build against the platform qt in the meantime? The qt tests aren't very worthwhile, but building against qt was a good way to make sure a full compilation still works.
-
MarcoFalke commented at 3:12 PM on May 9, 2016: member
Concept NACK per above discussion but I am leaving this open as an issue to indicate something needs to be done here.
- MarcoFalke closed this on May 23, 2016
- MarcoFalke deleted the branch on May 23, 2016
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels