Fix Minimize to the tray instead of the taskbar

Matoking commented at 6:14 pm on February 3, 2012: contributor

The “Minimize to the tray instead of the taskbar” option in Options should now work correctly.

luke-jr commented at 6:23 pm on February 3, 2012: member

It already works correctly for me. What does this fix?

laanwj commented at 6:29 pm on February 3, 2012: member

@luke-jr: it fails in some cases, see #788, #692

luke-jr commented at 6:30 pm on February 3, 2012: member

Does this make #691 unnecessary?

Matoking commented at 6:59 pm on February 3, 2012: contributor

It could be possible to have a single QWidget for this instead of creating and setting the new one to parent every time.

Then there is the possibility of setting the parent to NULL in both cases, but window dimensions won’t be preserved that way as far as I know.

laanwj commented at 11:34 am on February 5, 2012: member

Preserving window dimensions is nice to have ― I’d go for creating a single dummy QWidget in the constructor, storing it on the BitcoinGUI object.

Matoking commented at 3:21 pm on February 5, 2012: contributor

The latest commit preserves the window dimensions but not the window position (it appears at the top-right position on the screen at least on Ubuntu)

luke-jr commented at 2:52 pm on February 6, 2012: member

git reset –hard master git diff f69b82e..d5dc7c91 | patch -p1 git add src/qt/bitcoingui.{cpp,h} git commit -c b65a3532

gavinandresen commented at 3:16 pm on February 6, 2012: contributor

Diff look OK to me, but this does need to be rebased.

Matoking commented at 6:31 pm on February 6, 2012: contributor

Git really makes me want to pull out my hair sometimes.

*Fix Minimize to the tray instead of the taskbar

Avoid advertising the node's address when it is not listening or IsInitialBlockDownload().

This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.

Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.

Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.

Change up/down increment in UI to 0.001 BTC (issue #760)

Dummy widget for preserving window state after restoring from system tray

Took some build dependincies off

*Fix Minimize to the tray instead of the taskbar

Restored changes

Avoid advertising the node's address when it is not listening or IsInitialBlockDownload().

This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.

Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.

Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.

Change up/down increment in UI to 0.001 BTC (issue #760)

miniupnpc Porfile removed; new and improved macdeployqtplus

* My patch for miniupnpc has made it into the latest MacPorts release: https://trac.macports.org/ticket/31354
* Documentation has been changed appropriately
* New pure-Python macdeployqt; leverages all problems with the stock macdeployqt

Mac deploy tool: make dylibs writeable when copying into app bundle, so they can be stripped/nametool'ed

fetch translations from transifex

* fixes issue #742
* new translations: cs_CZ fa fi fr_FR hr pl ro_RO sv tr

Restructure credit transaction decomposition (solves issue #689)

When a transaction has multiple outputs that go to the wallet, list these
as multiple transactions in the UI. This is also applied to generated
(coinbase) transactions. Also makes the code shorter and easier
to understand.

Have bitcoind recommend a secure RPC password. Increase invalid password delay.

Help users avoid insecure configurations a bit by recommending a
secure RPC password and increasing the incorrect password delay.

This may open up a RPC DOS for users with exposed RPC ports and
short passwords. Since users shouldn't have exposed RPC ports OR
short passwords, the DOS risk is preferable to the compromise
risk.

Also logs the client IP address for incorrect attempts.

-bip16 option (default: 1) to support / not support BIP 16. And bumped default BIP16 switchover date from Feb 15 to Mar 1

Make transactions with extra data in their scriptSig's non-standard.

Unit tests for the GetArg() methods

New GetArg features: allow --, and booleans can be -foo or -nofoo

Look for flushwallet/listen/irc/dnsseed/upnp instead of noflushwallet/etc. And switch default for irc to 0.

Increase client version to 0.6

Update all copyrights to 2012

Update zlib and libpng (previous version had a security issue)

Split smaller dependencies out of gitian-win32 into deps-win32

Update doc/release-process.txt

Update readme-qt.rst for 0.6.0

- Remove features list (no longer makes sense)
- Document USE_QRCODE

a5a5d3c445

Matoking commented at 1:57 pm on February 9, 2012: contributor

Okay, everything should be in order now.

laanwj commented at 3:38 pm on February 11, 2012: member

@matoking can you try #826 and verify it still fixes your problem (I’ve reworked it a bit so that it works for Ubuntu too…)?

laanwj commented at 9:50 am on February 12, 2012: member

#826 was merged, closing this one, thanks!

laanwj closed this on Feb 12, 2012

destenson referenced this in commit d82680af1b on Jun 26, 2016

destenson referenced this in commit 16671cdf9a on Jun 26, 2016

ptschip referenced this in commit 98fa11bf40 on Oct 13, 2017

Losangelosgenetics referenced this in commit 1c2a034e23 on Mar 12, 2020

Losangelosgenetics referenced this in commit 6a9cfb866f on Mar 12, 2020

Losangelosgenetics referenced this in commit f3d6a361e0 on Mar 12, 2020

KolbyML referenced this in commit e61f804b0f on Aug 2, 2020

KolbyML referenced this in commit b9747625ca on Aug 2, 2020

KolbyML referenced this in commit 8e7f1ce38f on Aug 5, 2020

sipa referenced this in commit a951950cf7 on Aug 16, 2020

sipa referenced this in commit 0a0db15fc7 on Aug 16, 2020

sipa referenced this in commit 5d5bef0862 on Aug 28, 2020

sipa referenced this in commit 62da1445ac on Sep 4, 2020

sipa referenced this in commit f0c6824af2 on Sep 5, 2020

sipa referenced this in commit b9c1a76481 on Sep 11, 2020

KolbyML referenced this in commit 909d47d5d0 on Nov 21, 2020

DrahtBot locked this on Sep 8, 2021

Fix Minimize to the tray instead of the taskbar #795