It is always 'true', so useless.
Remove useless argument to AlertNotify. #7958
pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20160427_AlertNotify_remove_arg changing 1 files +6 −9-
paveljanik commented at 4:09 PM on April 27, 2016: contributor
-
b02119e463
Remove useless argument to AlertNotify.
It is always 'true', so useless.
- MarcoFalke added the label Refactoring on Apr 27, 2016
-
mruddy commented at 11:47 PM on April 27, 2016: contributor
yep, appears to be the case. utACK
-
kirkalx commented at 1:56 AM on April 28, 2016: contributor
I'm not entirely sure I agree with this but perhaps it is justified. If in the future somebody needs to call what would have been AlertNotify with fThread = false, then is it obvious how to re-add support for that situation? Or is that never going to be the case? If the answer to either is yes, then conceptACK from me.
-
paveljanik commented at 5:10 AM on April 28, 2016: contributor
@kirkalx Excuse me, I forgot to link to the previous issue (#7810). It (and a lot more) was discussed there.
-
kirkalx commented at 7:50 AM on April 28, 2016: contributor
Thanks for the link @paveljanik, some useful context there. I am also satisfied that the answer to my first question is yes, so utACK b02119e4634f2453260bb1b195e39bdc0a3b5691 from me.
-
laanwj commented at 9:56 AM on April 28, 2016: member
If in the future somebody needs to call what would have been AlertNotify with fThread = false, then is it obvious how to re-add support for that situation?
It can always be brought back. We use source control for a reason. Dead code (especially in main.cpp) should go.
utACK https://github.com/bitcoin/bitcoin/pull/7958/commits/b02119e4634f2453260bb1b195e39bdc0a3b5691
-
MarcoFalke commented at 3:04 PM on May 4, 2016: member
utACK b02119e
-
sipa commented at 4:35 PM on May 5, 2016: member
utACK b02119e4634f2453260bb1b195e39bdc0a3b5691
- laanwj merged this on May 9, 2016
- laanwj closed this on May 9, 2016
- laanwj referenced this in commit a68f56e727 on May 9, 2016
- codablock referenced this in commit afad946416 on Sep 16, 2017
- codablock referenced this in commit dc27bb76bd on Sep 19, 2017
- codablock referenced this in commit 3d665aa485 on Dec 21, 2017
- CryptoCentric referenced this in commit 3a3fd5acaa on Feb 15, 2019
- PastaPastaPasta referenced this in commit 2e289a4fc1 on Jun 20, 2019
- PastaPastaPasta referenced this in commit 7b16ae593f on Jun 20, 2019
- PastaPastaPasta referenced this in commit 434028fc10 on Jun 20, 2019
- PastaPastaPasta referenced this in commit c6b926547c on Jun 22, 2019
- barrystyle referenced this in commit 4788eccd09 on Jan 22, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels