build: No need to check for leveldb atomics #7982

pull theuni wants to merge 1 commits into bitcoin:master from theuni:leveldb-atomics changing 2 files +2 −19

theuni commented at 10:29 PM on April 30, 2016: member

They're guaranteed with c++11
build: No need to check for leveldb atomics
They're guaranteed with c++11
de98290155
paveljanik commented at 7:03 AM on May 1, 2016: contributor

utACK https://github.com/bitcoin/bitcoin/pull/7982/commits/de982901555b3f168a721a8911dc1ce8a51d3f59
MarcoFalke added the label Build system on May 1, 2016
laanwj commented at 12:23 PM on May 2, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/7982/commits/de982901555b3f168a721a8911dc1ce8a51d3f59

This reminds me, we should make tinyformat use variadic template as well (TINYFORMAT_USE_VARIADIC_TEMPLATES) if that's not the case yet automatically.
laanwj commented at 12:26 PM on May 2, 2016: member
A quick test shows that it auto-detects and uses them automatically, at least on clang 3.9:
```
#ifdef TINYFORMAT_USE_VARIADIC_TEMPLATES
#error Using variadic templates
#endif
```
The detection method is a tad outdated though:
```
#   ifdef __GXX_EXPERIMENTAL_CXX0X__
#       define TINYFORMAT_USE_VARIADIC_TEMPLATES
#   endif
```
theuni commented at 7:35 PM on May 2, 2016: member

@laanwj Agreed, defining it explicitly couldn't hurt.
laanwj merged this on May 4, 2016
laanwj closed this on May 4, 2016
laanwj referenced this in commit 559fbae8c6 on May 4, 2016
laanwj referenced this in commit 9eaa0afa6e on May 4, 2016
deadalnix referenced this in commit 63478a727b on Jan 11, 2017
deadalnix referenced this in commit 9ec3eb7421 on Jan 11, 2017
deadalnix referenced this in commit a4d32dd7f7 on Jan 15, 2017
deadalnix referenced this in commit edf009ad1a on Jan 16, 2017
deadalnix referenced this in commit f436dbb861 on Jan 17, 2017
deadalnix referenced this in commit c991d4c975 on Jan 19, 2017
deadalnix referenced this in commit b98ec8a41c on Jan 19, 2017
dagurval referenced this in commit 4473e43402 on Apr 23, 2017
codablock referenced this in commit c05292da76 on Sep 16, 2017
codablock referenced this in commit a51ef38a86 on Sep 19, 2017
codablock referenced this in commit 6662e23a0a on Dec 20, 2017
lateminer referenced this in commit a2b5a784ca on Oct 21, 2018
zkbot referenced this in commit 59d6a92e7d on Sep 22, 2020
zkbot referenced this in commit 514d868179 on Sep 25, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8000 tinyformat: force USE_VARIADIC_TEMPLATES