It's never accessed or modified, and is needlessly checked for validity in the rpc command.
Remove state arg from ReconsiderBlock, rename to ResetBlockFailureFlags #8019
pull instagibbs wants to merge 2 commits into bitcoin:master from instagibbs:reblarg changing 3 files +5 −7-
instagibbs commented at 5:28 PM on May 6, 2016: member
-
Remove state arg from ReconsiderBlock addb9d2a09
-
pstratem commented at 1:07 AM on May 7, 2016: contributor
Possibly ReconsiderBlock should be renamed ResetBlockFlags or something?
It doesn't actually reconsider the block.
-
instagibbs commented at 2:03 AM on May 7, 2016: member
That is true as well.
- MarcoFalke added the label Refactoring on May 8, 2016
-
Rename ReconsiderBlock func to reflect real behavior 657e07efa3
- instagibbs renamed this:
Remove state arg from ReconsiderBlock
Remove state arg from ReconsiderBlock, rename to ResetBlockFailureFlags
on May 9, 2016 -
sipa commented at 7:28 PM on May 9, 2016: member
utACK 657e07efa34ffe9d8614a618e00452c9ee7c0e0d
-
paveljanik commented at 8:11 PM on May 9, 2016: contributor
-
dcousens commented at 7:03 AM on May 10, 2016: contributor
utACK 657e07e
- laanwj merged this on May 10, 2016
- laanwj closed this on May 10, 2016
- laanwj referenced this in commit f7a21dae5d on May 10, 2016
- codablock referenced this in commit 0824939443 on Sep 16, 2017
- codablock referenced this in commit c9b49481d9 on Sep 19, 2017
- codablock referenced this in commit 3dbae2d321 on Dec 21, 2017
- MarkLTZ referenced this in commit 3120c258d3 on Apr 27, 2019
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels