This should fix the issue:
bip9-softforks.pyfails withBDB3028 blocks.db: unable to flush: No such file or directory
This should fix the issue:
bip9-softforks.pyfails withBDB3028 blocks.db: unable to flush: No such file or directory
Just verified this fixes the issue I was seeing. Thanks!
ACK
@MarcoFalke What is weird is the error only appears when running the test individually, but not as part of the pull-tester.py suite.
@MarcoFalke Can you please help me understand, what was the problem? If I understand it and am able to reproduce, I'd feel better 👍
Edit: FWIW: it never failed for me locally, either by running it individually or as part of the pull-tester.
@paveljanik It never failed for me locally, either. But I assume the failure (print to stderr) is caused by deleting the blocks.db and not closing the db connection.
@btcdrak It should fail for both, though. The pull tester is only a convenience wrapper, so you don't have to type each command by yourself. (c.f. https://github.com/bitcoin/bitcoin/blob/423ca302a3ee87000530da3c105f269b8fabece7/qa/pull-tester/rpc-tests.py#L248)
I can confirm this fixes the issue of isolated runs.
ACK fa0f635
I have removed the changes to comptool.py, as they are not required. (Now it is a +3-0 diff; I don't think I can get it any smaller ;)