[qa] Fix bip9-softforks blockstore issue #8041

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1604-qaBip9Blockstore changing 1 files +3 −0
  1. MarcoFalke commented at 11:13 AM on May 11, 2016: member

    @sdaftuar

    This should fix the issue:

    bip9-softforks.py fails with BDB3028 blocks.db: unable to flush: No such file or directory

  2. MarcoFalke added the label Tests on May 11, 2016
  3. sdaftuar commented at 12:16 PM on May 11, 2016: member

    Just verified this fixes the issue I was seeing. Thanks!

    ACK

  4. btcdrak commented at 12:23 PM on May 11, 2016: contributor

    @MarcoFalke What is weird is the error only appears when running the test individually, but not as part of the pull-tester.py suite.

  5. paveljanik commented at 12:24 PM on May 11, 2016: contributor

    @MarcoFalke Can you please help me understand, what was the problem? If I understand it and am able to reproduce, I'd feel better 👍

    Edit: FWIW: it never failed for me locally, either by running it individually or as part of the pull-tester.

  6. MarcoFalke commented at 12:32 PM on May 11, 2016: member

    @paveljanik It never failed for me locally, either. But I assume the failure (print to stderr) is caused by deleting the blocks.db and not closing the db connection.

  7. MarcoFalke commented at 12:34 PM on May 11, 2016: member

    @btcdrak It should fail for both, though. The pull tester is only a convenience wrapper, so you don't have to type each command by yourself. (c.f. https://github.com/bitcoin/bitcoin/blob/423ca302a3ee87000530da3c105f269b8fabece7/qa/pull-tester/rpc-tests.py#L248)

  8. btcdrak commented at 12:38 PM on May 11, 2016: contributor

    I can confirm this fixes the issue of isolated runs.

    ACK fa0f635

  9. [qa] Fix bip9-softforks blockstore issue fad60b3911
  10. MarcoFalke force-pushed on May 11, 2016
  11. MarcoFalke commented at 8:29 PM on May 11, 2016: member

    I have removed the changes to comptool.py, as they are not required. (Now it is a +3-0 diff; I don't think I can get it any smaller ;)

  12. laanwj merged this on May 12, 2016
  13. laanwj closed this on May 12, 2016

  14. laanwj referenced this in commit 5b736ddaa1 on May 12, 2016
  15. MarcoFalke deleted the branch on May 12, 2016
  16. codablock referenced this in commit 5369d5ac83 on Sep 16, 2017
  17. codablock referenced this in commit bdbdf0c1db on Sep 19, 2017
  18. codablock referenced this in commit f0fe21d372 on Dec 21, 2017
  19. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me