[qa] Remove hardcoded "4 nodes" from test_framework #8056

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1605-qaFlex changing 58 files +291 −138

MarcoFalke commented at 9:18 AM on May 15, 2016: member
This is the first pull of two to remove the hardcoded 4 nodes from test_framework.py. This includes several benefits, which come for free:
- Each derived test can now set the number of nodes in __init__() and have the base class deal with setting up the network. This makes the test easier to read and easier for newcomers to get started writing tests, hopefully.
- Also, __init__() is used to specify if the chain should be clean (default=False), instead of calling the util function directly.
MarcoFalke added the label Tests on May 15, 2016
MarcoFalke force-pushed on May 15, 2016
MarcoFalke force-pushed on May 15, 2016
MarcoFalke added the label Refactoring on May 15, 2016
[qa] Remove hardcoded "4 nodes" from test_framework fac9349798
[qa] Reduce node count for some tests fad68f751a
MarcoFalke force-pushed on May 15, 2016
MarcoFalke commented at 11:16 AM on May 15, 2016: member

Added a commit to reduce the node count for some tests.
btcdrak commented at 12:53 PM on May 15, 2016: contributor

utACK fad68f7
laanwj commented at 9:28 AM on May 18, 2016: member

ut/Concept ACK https://github.com/bitcoin/bitcoin/pull/8056/commits/fad68f751aff024bcbc1587640c3591aab5a80f7

in qa/rpc-tests/multi_rpc.py:None in fad68f751a

   7 | @@ -8,25 +8,31 @@
   8 |  #
   9 |  
  10 |  from test_framework.test_framework import BitcoinTestFramework
  11 | -from test_framework.util import *
  12 | +from test_framework.util import str_to_b64str, assert_equal

jtimon commented at 1:04 PM on May 20, 2016:

Nice, explicit is better than implicit.

jtimon commented at 1:07 PM on May 20, 2016: contributor

utACK fad68f7
MarcoFalke merged this on May 20, 2016
MarcoFalke closed this on May 20, 2016
MarcoFalke referenced this in commit 8844ef15de on May 20, 2016
MarcoFalke deleted the branch on May 20, 2016
codablock referenced this in commit 5f4eb1b8e4 on Sep 16, 2017
codablock referenced this in commit 6604d3d6e5 on Sep 19, 2017
codablock referenced this in commit bcecdcd8e9 on Dec 21, 2017
zkbot referenced this in commit 025bd44543 on Nov 21, 2020
zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
zkbot referenced this in commit c8896f9907 on Dec 2, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8713 [qa] create_cache: Delete temp dir when done