Improvements to the CWallet API which can be made without a negative performance impact.
[Wallet] Improve Wallet encapsulation #8061
pull pstratem wants to merge 2 commits into bitcoin:master from pstratem:2016-05-14-wallet-api-cleanup changing 6 files +80 −78-
pstratem commented at 12:22 AM on May 17, 2016: contributor
-
Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance ecb9741ec3
-
Move BackupWallet to CWallet::BackupWallet 380498aba4
- pstratem force-pushed on May 17, 2016
- pstratem force-pushed on May 17, 2016
-
dcousens commented at 2:15 AM on May 17, 2016: contributor
utACK 380498a
On another note,
CWalletis doing way too much at this point. The movement of these functions intoCWalletfall under its current responsibilities, it just simply has too many responsibilities. No doubt we're quite the stones throw away from it following the single responsibility principle haha. -
jonasschnelli commented at 7:37 AM on May 17, 2016: contributor
utACK 380498aba4f6aebe53a8241f163e3c7fe424b7e0
- jonasschnelli added the label Wallet on May 17, 2016
-
MarcoFalke commented at 8:23 AM on May 17, 2016: member
utACK 380498a
-
paveljanik commented at 6:22 PM on May 17, 2016: contributor
- MarcoFalke added the label Refactoring on May 21, 2016
-
arowser commented at 8:43 AM on May 25, 2016: contributor
Can one of the admins verify this patch?
-
sipa commented at 4:06 PM on May 25, 2016: member
ACK, Confirmed move-only ecb9741ec3067f67f595126869d0200c62064bbd and 380498aba4f6aebe53a8241f163e3c7fe424b7e0.
- sipa merged this on May 25, 2016
- sipa closed this on May 25, 2016
- sipa referenced this in commit f6b7df3155 on May 25, 2016
- codablock referenced this in commit 05e3aed29e on Sep 16, 2017
- codablock referenced this in commit 182fd205c1 on Sep 19, 2017
- codablock referenced this in commit 8723f99569 on Dec 21, 2017
- zkbot referenced this in commit 5b194067ea on Aug 12, 2021
- MarcoFalke locked this on Sep 8, 2021
