This gets rid of the hardcoded user='rt', pass='rt'.
[qa] test_framework: Use different rpc_auth_pair for each node #8066
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1605-qaAuthPairDiff changing 1 files +8 −3-
MarcoFalke commented at 9:08 AM on May 17, 2016: member
-
[qa] test_framework: Use different rpc_auth_pair for each node fad184550e
- MarcoFalke added the label Tests on May 17, 2016
-
paveljanik commented at 6:17 PM on May 17, 2016: contributor
-
sipa commented at 6:19 PM on May 17, 2016: member
Is there a benefit to having different rpcauth pairs for each node?
(that's a separate question from not hardcoding it)
-
-
laanwj commented at 8:44 AM on May 18, 2016: member
But one drawback I can see of this is that it makes it more difficult to diagnose after a non-cleanup test run, or interrogating a bitcoind stuck around after a crashing test. No longer is the user/password to query it obvious.
- MarcoFalke force-pushed on May 18, 2016
-
MarcoFalke commented at 4:08 PM on May 18, 2016: member
Indeed this is the drawback, which would mean I better remove the fancy utf-8 chars as well...
Obviously we are running the daemons on different ports, so within the test framework it is more than unlikely to accidentally speak to the wrong daemon. I think a reasonable compromise would be to use
'rt_u'+str(n)and'rt_p'+str(n). - MarcoFalke force-pushed on May 21, 2016
-
laanwj commented at 1:45 PM on May 21, 2016: member
No longer is the user/password to query it obvious.
I just realized this may be a smaller problem than I thought: we write a bitcoin.conf in every node directory with the user/password information so
bitcoin-cli -datadir=$DIRcan be used. As the directory is printed to stdout, I think there is not really a problem with 'guessing' the user/password. - MarcoFalke force-pushed on May 21, 2016
- MarcoFalke force-pushed on Jun 3, 2016
-
laanwj commented at 11:41 AM on June 20, 2016: member
ACK fad1845
- laanwj merged this on Jun 20, 2016
- laanwj closed this on Jun 20, 2016
- laanwj referenced this in commit 65c2058cc8 on Jun 20, 2016
- MarcoFalke deleted the branch on Jun 20, 2016
- codablock referenced this in commit b46d2f1b12 on Sep 16, 2017
- codablock referenced this in commit 3780c5ae9a on Sep 19, 2017
- codablock referenced this in commit 9d367fdf0f on Dec 27, 2017
- codablock referenced this in commit 782745b05b on Dec 28, 2017
- andvgal referenced this in commit 56d20216e6 on Jan 6, 2019
- zkbot referenced this in commit 025bd44543 on Nov 21, 2020
- zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
- zkbot referenced this in commit c8896f9907 on Dec 2, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels