Remove non-determinism which is breaking net_tests #8069 #8070

1. 
   EthanHeilman commented at 4:08 pm on May 18, 2016: contributor

   If addrmanUncorrupted does not have the same nKey every time it will map addrs to different bucket positions and occasionally cause a collision between two addrs, breaking the test.
2. Remove non-determinism which is breaking net_tests #8069 f4119c6c98
3. in src/test/net_tests.cpp: in 99427c71a8 outdated

   12@@ -13,10 +13,18 @@
   13 
   14 using namespace std;
   15 
   16+
   

   ---

   ---

   

   instagibbs commented at 4:23 pm on May 18, 2016:

   extra line
4. 
   paveljanik commented at 7:44 pm on May 18, 2016: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/8070/commits/f4119c6c988ea24a5218aa6bc67e57e47e051547

   To reproduce the problem without this change:

   0for i in {1..10000}; do echo $i; ./test_bitcoin --run_test=net_tests || break; done
   1...
   2Running 2 test cases...
   3test/net_tests.cpp:92: error in "caddrdb_read": check addrman1.size() == 3 failed
   4test/net_tests.cpp:102: error in "caddrdb_read": check addrman2.size() == 3 failed
   5
   6*** 2 failures detected in test suite "Bitcoin Test Suite"
   

   When you are here, please fix s/adddrman/addrman/ here: https://github.com/bitcoin/bitcoin/pull/8070/commits/f4119c6c988ea24a5218aa6bc67e57e47e051547#diff-03fc2f333374fd229824451793c40462R131

5. Fix typo adddrman to addrman as requested in #8070 2a8b3589b5
6. laanwj merged this on May 19, 2016
7. laanwj closed this on May 19, 2016

   ---

8. laanwj referenced this in commit 7771aa57bd on May 19, 2016
9. sickpig referenced this in commit 16969f5d33 on May 2, 2017
10. dexX7 referenced this in commit a400d26561 on Jun 8, 2017
11. dexX7 referenced this in commit 2476c64723 on Jun 8, 2017
12. dexX7 referenced this in commit 3edbe7cc79 on Jun 8, 2017
13. codablock referenced this in commit 03e8f777c9 on Sep 16, 2017
14. codablock referenced this in commit 4bafc7f5ab on Sep 19, 2017
15. codablock referenced this in commit 8eeaa4f212 on Dec 21, 2017
16. lateminer referenced this in commit bec58f282f on Nov 11, 2018
17. furszy referenced this in commit a5288eca97 on Mar 23, 2020
18. zkbot referenced this in commit eb8dac51a8 on Jun 15, 2021
19. DrahtBot locked this on Sep 8, 2021

Contributors
EthanHeilman instagibbs paveljanik