Tests: add timeout to sync_blocks() and sync_mempools() #8104

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:improve-rpc-sync changing 1 files +13 −9

sdaftuar commented at 6:40 PM on May 26, 2016: member

Previously these functions would infinitely loop if sync failed; now they have a default timeout of 60 seconds, after which an AssertionError is raised.

sync_blocks() has also been improved and now compares the tip hash of each node, rather than just using block count.

Tests: add timeout to sync_blocks() and sync_mempools()

Previously these functions would infinitely loop if sync failed;
now they have a default timeout of 60 seconds, after which an
AssertionError is raised.

sync_blocks() has also been improved and now compares the tip
hash of each node, rather than just using block count.

e871f8338a

MarcoFalke commented at 6:47 PM on May 26, 2016: member

Thanks! Concept ACK.
sipa commented at 10:25 PM on May 26, 2016: member

utACK e871f8338ad180428ff997b80a476d9719d8073f
jonasschnelli commented at 12:45 PM on May 27, 2016: contributor

utACK e871f8338ad180428ff997b80a476d9719d8073f
MarcoFalke merged this on May 29, 2016
MarcoFalke closed this on May 29, 2016
MarcoFalke referenced this in commit 6ff2c8d29f on May 29, 2016
laanwj commented at 7:19 AM on May 30, 2016: member

sync_blocks() has also been improved and now compares the tiphash of each node

Good idea
codablock referenced this in commit 0a2850d44f on Sep 16, 2017
codablock referenced this in commit a5305dab31 on Sep 19, 2017
codablock referenced this in commit 0027292ac6 on Dec 21, 2017
andvgal referenced this in commit 6d7d007cd2 on Jan 6, 2019
zkbot referenced this in commit 025bd44543 on Nov 21, 2020
zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
zkbot referenced this in commit c8896f9907 on Dec 2, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8280 Tests: Increase sync_blocks() timeouts in pruning.py