Improve CWallet API with new GetAccountPubkey function. #8142

pull pstratem wants to merge 1 commits into bitcoin:master from pstratem:2016-06-02-cwallet-getaccountpubkey changing 3 files +43 −30

pstratem commented at 6:18 AM on June 3, 2016: contributor

Remove one more caller that is passing CWalletDB
MarcoFalke added the label Wallet on Jun 3, 2016
MarcoFalke commented at 11:46 AM on June 3, 2016: member

Travis didn't fetch this one. Mind to do a "null-rebase" and force-push?
pstratem force-pushed on Jun 3, 2016
pstratem commented at 1:30 PM on June 3, 2016: contributor

@MarcoFalke done
laanwj commented at 2:00 PM on June 3, 2016: member

Concept ACK

There does seem to be a pattern lately to move more and more code to the CWallet class, and we do need to split that up at some point, but I agree that these implementation details don't belong in the RPC code and that this is better locking-wise.
pstratem commented at 2:28 PM on June 3, 2016: contributor

@laanwj I'm going to be working on improving the wallet in general but that's very difficult to do when there's code all over the place.

This is just the logical first step.
MarcoFalke commented at 3:44 PM on June 3, 2016: member

utACK 8eb28b6
Improve CWallet API with new GetAccountPubkey function.
Remove one more caller that is passing CWalletDB.
152ab236ea
pstratem force-pushed on Jun 6, 2016
laanwj commented at 2:27 PM on June 6, 2016: member

Checked move-only, utACK https://github.com/bitcoin/bitcoin/commit/8eb28b61ee32369169bbabbe8e8b14361ebe292d
laanwj merged this on Jun 6, 2016
laanwj closed this on Jun 6, 2016
laanwj referenced this in commit 52c3f348be on Jun 6, 2016
sipa commented at 2:33 PM on June 6, 2016: member
Posthumous move-only utACK 152ab236ea1c1106340196f45918fd84f57a0b63

For reference:
```
git diff -w --patience --word-diff=color 152ab23~:src/wallet/rpcwallet.cpp 152ab23:src/wallet/wallet.cpp
```
codablock referenced this in commit 051672ab10 on Sep 16, 2017
codablock referenced this in commit 198c9dada5 on Sep 19, 2017
codablock referenced this in commit b2bd69a7a9 on Dec 22, 2017
andvgal referenced this in commit 84d8fda0d3 on Jan 6, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels