Use SipHash for node eviction (cont’d) #8173

1. 
   laanwj commented at 1:52 pm on June 8, 2016: member

   Add full test vectors from spec, test per byte and per 8 bytes.

   Builds on #8086 (as it adds per-byte hashing).

2. Avoid recalculating vchKeyedNetGroup in eviction logic.

   Lazy calculate vchKeyedNetGroup in CNode::GetKeyedNetGroup.

   053930ffc4
3. Support SipHash with arbitrary byte writes 9bf156bb9e
4. Use 64-bit SipHash of netgroups in eviction c31b24f745
5. Use C++11 thread-safe static initializers 888483098e
6. test: Add more test vectors for siphash

   Add full test vectors from spec, test per byte and per 8 bytes.
   
   Builds on #8086.

   eebc232187
7. laanwj added the label Tests on Jun 8, 2016
8. 
   sipa commented at 1:54 pm on June 8, 2016: member

   utACK eebc23218758d89bce0b7cb0eced9fd654cd3d15
9. 
   instagibbs commented at 1:59 pm on June 8, 2016: member

   May want to re-title this PR
10. 
    sipa commented at 2:03 pm on June 8, 2016: member

    The original had grown in scope anyway, it now does:

    • Extend the SipHash implementation
    • Improved comments
    • Added tests
    • Switched to thread-safe random seed initializers
    • Switch node eviction to use siphash
11. laanwj renamed this:
    test: Add more test vectors for siphash
    Use SipHash for node eviction (cont'd)
    on Jun 8, 2016
12. 
    NicolasDorier commented at 4:02 pm on June 8, 2016: contributor

    tACK on the purely Siphash part (reimplemented this PR tests included into NBitcoin successfully on https://github.com/MetacoSA/NBitcoin/commit/c915829c0e4595d49c357525c9c51b4cb52f4b7f)
13. sipa merged this on Jun 8, 2016
14. sipa closed this on Jun 8, 2016

    ---

15. sipa referenced this in commit 4286f43025 on Jun 8, 2016
16. 
    sipa commented at 7:18 am on June 9, 2016: member

    #8086 had plenty of ACKs and this did only add tests, which also got ACKs.

    You complained in #8086 about it being insecure. If you can explain how, I’ll gladly revert the siphash-for-eviction part.

17. 
    laanwj commented at 7:44 am on June 9, 2016: member

    @sipa it’s not clear who or what you’re replying to

    In any case, it was time to merge this, there were no concrete concerns left.

18. MarcoFalke added the label P2P on Jun 9, 2016
19. MarcoFalke removed the label Tests on Jun 9, 2016
20. 
    rebroad commented at 8:54 am on August 9, 2016: contributor

    What is a SipHash?
21. 
    sipa commented at 8:56 am on August 9, 2016: member

    https://131002.net/siphash/
22. codablock referenced this in commit 1a5f9b2ee4 on Sep 19, 2017
23. codablock referenced this in commit fb8d277c98 on Sep 27, 2017
24. codablock referenced this in commit 2fa49e8cdc on Oct 12, 2017
25. codablock referenced this in commit 60e6a602e6 on Oct 19, 2017
26. UdjinM6 referenced this in commit d41afae836 on Nov 8, 2017
27. codablock referenced this in commit 361d26037b on Dec 22, 2017
28. andvgal referenced this in commit e3e73a8088 on Jan 6, 2019
29. furszy referenced this in commit bda654c5f3 on Aug 5, 2020
30. zkbot referenced this in commit 89d9e557e1 on Feb 17, 2021
31. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj sipa instagibbs NicolasDorier rebroad

Labels
P2P