Use SipHash for node eviction (cont'd) #8173

pull laanwj wants to merge 5 commits into bitcoin:master from laanwj:2016_06_siphash_testing changing 8 files +152 −62

laanwj commented at 1:52 PM on June 8, 2016: member

Add full test vectors from spec, test per byte and per 8 bytes.

Builds on #8086 (as it adds per-byte hashing).
Avoid recalculating vchKeyedNetGroup in eviction logic.
Lazy calculate vchKeyedNetGroup in CNode::GetKeyedNetGroup.
053930ffc4
Support SipHash with arbitrary byte writes 9bf156bb9e
Use 64-bit SipHash of netgroups in eviction c31b24f745
Use C++11 thread-safe static initializers 888483098e

test: Add more test vectors for siphash

Add full test vectors from spec, test per byte and per 8 bytes.

Builds on #8086.

eebc232187

laanwj added the label Tests on Jun 8, 2016
sipa commented at 1:54 PM on June 8, 2016: member

utACK eebc23218758d89bce0b7cb0eced9fd654cd3d15
instagibbs commented at 1:59 PM on June 8, 2016: member

May want to re-title this PR
sipa commented at 2:03 PM on June 8, 2016: member
The original had grown in scope anyway, it now does:
- Extend the SipHash implementation
- Improved comments
- Added tests
- Switched to thread-safe random seed initializers
- Switch node eviction to use siphash
laanwj renamed this:
~~test: Add more test vectors for siphash~~
Use SipHash for node eviction (cont'd)
on Jun 8, 2016
NicolasDorier commented at 4:02 PM on June 8, 2016: contributor

tACK on the purely Siphash part (reimplemented this PR tests included into NBitcoin successfully on https://github.com/MetacoSA/NBitcoin/commit/c915829c0e4595d49c357525c9c51b4cb52f4b7f)
sipa merged this on Jun 8, 2016
sipa closed this on Jun 8, 2016
sipa referenced this in commit 4286f43025 on Jun 8, 2016
sipa commented at 7:18 AM on June 9, 2016: member

#8086 had plenty of ACKs and this did only add tests, which also got ACKs.

You complained in #8086 about it being insecure. If you can explain how, I'll gladly revert the siphash-for-eviction part.
laanwj commented at 7:44 AM on June 9, 2016: member

@sipa it's not clear who or what you're replying to

In any case, it was time to merge this, there were no concrete concerns left.
MarcoFalke added the label P2P on Jun 9, 2016
MarcoFalke removed the label Tests on Jun 9, 2016
rebroad commented at 8:54 AM on August 9, 2016: contributor

What is a SipHash?
sipa commented at 8:56 AM on August 9, 2016: member

https://131002.net/siphash/
codablock referenced this in commit 1a5f9b2ee4 on Sep 19, 2017
codablock referenced this in commit fb8d277c98 on Sep 27, 2017
codablock referenced this in commit 2fa49e8cdc on Oct 12, 2017
codablock referenced this in commit 60e6a602e6 on Oct 19, 2017
UdjinM6 referenced this in commit d41afae836 on Nov 8, 2017
codablock referenced this in commit 361d26037b on Dec 22, 2017
andvgal referenced this in commit e3e73a8088 on Jan 6, 2019
furszy referenced this in commit bda654c5f3 on Aug 5, 2020
zkbot referenced this in commit 89d9e557e1 on Feb 17, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8086 Use SipHash for node eviction