[0.12.2] backport: getblockchaininfo: make bip9_softforks an object, not an array. #8186

1. 
   MarcoFalke commented at 10:50 PM on June 9, 2016: member

   This breaks the interface but it was tagged with 'Needs backport' and I think it is useful. Other opinions?

2. MarcoFalke added the label RPC/REST/ZMQ on Jun 9, 2016
3. MarcoFalke added the label Backport on Jun 9, 2016
4. 
   laanwj commented at 6:44 AM on June 22, 2016: member

   Nah I think it makes sense to backport this in preparation for 0.13. Maybe mention in the release notes? Not sure how many people rely on this programmatically.

5. MarcoFalke force-pushed on Jun 22, 2016
6. getblockchaininfo: make bip9_softforks an object, not an array.

   Github-Pull: #7863
   Rebased-From: 85c807c9ead3215021503348e75851900dfa08db d12760b16ac30734b5e3b047df8aaf6564e927db

   feaa4ded1c
7. MarcoFalke force-pushed on Jun 22, 2016
8. MarcoFalke force-pushed on Jun 22, 2016
9. 
   MarcoFalke commented at 12:31 PM on June 23, 2016: member

   Updated the release notes just to be safe.

10. MarcoFalke added this to the milestone 0.12.0 on Jul 7, 2016
11. 
    MarcoFalke commented at 11:20 AM on July 11, 2016: member

    Anything holding this back?

12. 
    laanwj commented at 11:26 AM on July 11, 2016: member

    Nothing specific, just lack of review and testing as usual with backports. I'll take a look at it.

13. in doc/release-notes.md:None in fa038c41c5 outdated

      35 | @@ -36,10 +36,13 @@ earlier.
      36 |  Notable changes
      37 |  ===============
      38 |  
      39 | -Example item
      40 | ----------------------------------------
      41 | +Miscellaneous
    

    ---

    ---

    

    laanwj commented at 11:29 AM on July 11, 2016:

    Nit: usually we call this category "RPC low-level API changes" https://github.com/bitcoin/bitcoin/blob/v0.12.0/doc/release-notes.md#rpc-low-level-api-changes

14. MarcoFalke force-pushed on Jul 11, 2016
15. 
    laanwj commented at 11:47 AM on July 11, 2016: member

    0.12 without this patch:

      "bip9_softforks": [
        {
          "id": "csv",
          "status": "locked_in"
        }
      ]
    

    0.12 with this patch (yea, different chain):

      "bip9_softforks": {
        "csv": {
          "status": "started"
        }
      }
    

    Master:

      "bip9_softforks": {
        "csv": {
          "status": "active",
          "startTime": 1462060800,
          "timeout": 1493596800
        }
      }
    

    ACK fa4327c

16. 
    luke-jr commented at 11:47 AM on July 11, 2016: member

    Eh, breaking API compatibility in a bugfix release? I don't see any real benefit to this. If people want the new API, they can just use 0.13. We've never broken API compatibility before in even a major release... now isn't the time to do it in a bugfix release. :/

17. 
    laanwj commented at 11:50 AM on July 11, 2016: member

    The idea would be to have the same API on 0.12 and 0.13, which makes e.g. testing easier (also for e.g. segwit). But I don't care deeply whether this makes it into 0.12...

    You do have a point that this would be an API-breaking change in a minor releaese.

18. laanwj added this to the milestone 0.12.2 on Aug 16, 2016
19. laanwj removed this from the milestone 0.12.0 on Aug 16, 2016
20. [doc] Update release notes for change in getblockchaininfo fab67c115a
21. MarcoFalke force-pushed on Sep 9, 2016
22. 
    laanwj commented at 5:48 AM on September 22, 2016: member

    Closing this, apparently it is controversial

23. laanwj closed this on Sep 22, 2016

    ---

24. MarcoFalke deleted the branch on Sep 22, 2016
25. DrahtBot locked this on Sep 8, 2021

Contributors

MarcoFalkelaanwjluke-jr

Milestone
0.12.branch