Fix wx-config usage #82

pull mgiuca wants to merge 6 commits into bitcoin:master from mgiuca:wx-config changing 2 files +15 −20

mgiuca commented at 10:33 PM on February 25, 2011: contributor

Hi,

This is a response to the other pull request by ojab. I didn't want to make a new pull request but I couldn't find another way to do it.

The last comment by tcatm was "This patch works ... outputs annoying errors (wx-config not found) when building bitcoind. Can you fix that?"

I have fixed it in this branch (it no longer tries to include wx at all for any non-GUI files), and updated the readme to say it's OK to use wx 2.9.1 now. It now builds bitcoind just fine even if your system has no trace of wxWidgets.

1. Change hardcoded g++ to $(CXX)

2. Change CFLAGS to CXXFLAGS
3. Add binaries to clean target
4. Generate wxWidgets includes/ldflags/etc from wx-config

f0b7952caa

Merge https://github.com/ojab/bitcoin into wx-config 32e94947dc

makefile.unix: Removed redundant use of wx-config in DEFS (it was being included twice).

    Also changed wx-config --cppflags to --cxxflags. I am not sure what the
    difference is supposed to be, but --cppflags does not include -pthread.

8314b7f5e6

makefile.unix: WXINCLUDEPATHS now only used for building GUI object files.

    Moved it out of CXXFLAGS and into the command-line for the GUI objects.
    It will no longer be invoked for non-GUI and crypto object files.

3415b15a56

makefile.unix: Fixed errors building bitcoind without wxWidgets installed.

    WXINCLUDEPATHS and WXLIBS now assigned with '=' instead of ':='.
    This means they are only evaluated on-demand, and they will never be
    requested by 'make bitcoind', so it won't try to call wx-config.

84778a5b46

build-unix.txt: Updated (now OK to use wxWidgets > 2.9.0). 84711b18bc
glv2 referenced this in commit e4c2bf76c3 on Apr 15, 2014
rdponticelli referenced this in commit b0295868f4 on Nov 26, 2014
dexX7 referenced this in commit d44a0c5fe7 on Jun 25, 2015
ptschip referenced this in commit 8be92a4b0c on Sep 6, 2016
8bitcoder referenced this in commit 80ea2adbe3 on Jan 30, 2018
lateminer referenced this in commit 60ffdeda06 on Feb 23, 2019
attilaaf referenced this in commit bd20545f2b on Sep 20, 2019
cryptapus referenced this in commit 632048659e on May 3, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

mgiuca

Linked (view graph)

#52 Use wx-config for INCLUDEPATHS/WXLIBS #25323 miniscript fuzzer failing after qa-assets update