UI options proxy field can only take IPv4 addresses #821

1. 
   laanwj commented at 10:17 am on February 11, 2012: member

   Not a high-priority issue, as I don’t think many people use IPv6 proxies, but still it is a limitation. Field should also be widened in this case.
2. 
   sipa commented at 5:17 pm on February 11, 2012: member

   As we don’t actually have IPv6 support yet, i think this is not yet an issue.
3. 
   Diapolo commented at 1:53 pm on June 9, 2012: none

   As IPv6 support is in now, it could be as simple as updating this line: https://github.com/bitcoin/bitcoin/pull/1433/files#L2R42 (link to a non-merged pull)! @sipa Anything more to take into consideration?
4. 
   sipa commented at 2:36 pm on June 9, 2012: member

   Finding a regexp for IPv6 addresses shouldn’t be hard, but can’t we just have a validator that calls LookupNumeric from netbase.h? If that call succeeds, we’re fine.
5. 
   Diapolo commented at 9:57 pm on June 9, 2012: none

   sipa: I guess that would be pretty easy to do, can you explain what LookupNumeric() does. Allows it to verify IPv4/IPv6 addresses and host names?

   Edit: I’m missing a better documentation :), for me it’s still sometimes hard to understand such code pieces, when I first get in touch with them.

6. 
   sipa commented at 10:17 pm on June 9, 2012: member

   I’ll try to add some documentation there. It allows conversion of a string that contains a numeric address (e.g. “127.0.0.1”, “127.0.0.1:8333”, “[::1]:8333”, …) to a CService.
7. 
   Diapolo commented at 10:21 pm on June 9, 2012: none

   Thanks, this would be a great help!

   So this check would cover IPv4 and IPv6 addresses … are (in general) hostnames possible as a proxy input and how could I check that?

8. 
   Diapolo commented at 3:18 pm on June 22, 2012: none

   This is fixed with current master (which allows IPv6 addresses) and so can be closed!
9. laanwj closed this on Aug 18, 2012

   ---

10. lateminer referenced this in commit 86d6133735 on Mar 4, 2019
11. sipa referenced this in commit 52380bf304 on Oct 14, 2020
12. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj sipa Diapolo

Labels
GUI Refactoring