UI options proxy field can only take IPv4 addresses #821

Not a high-priority issue, as I don't think many people use IPv6 proxies, but still it is a limitation. Field should also be widened in this case.

As we don't actually have IPv6 support yet, i think this is not yet an issue.

As IPv6 support is in now, it could be as simple as updating this line: https://github.com/bitcoin/bitcoin/pull/1433/files#L2R42 (link to a non-merged pull)! @sipa Anything more to take into consideration?

Finding a regexp for IPv6 addresses shouldn't be hard, but can't we just have a validator that calls LookupNumeric from netbase.h? If that call succeeds, we're fine.

sipa: I guess that would be pretty easy to do, can you explain what LookupNumeric() does. Allows it to verify IPv4/IPv6 addresses and host names?

Edit: I'm missing a better documentation :), for me it's still sometimes hard to understand such code pieces, when I first get in touch with them.

I'll try to add some documentation there. It allows conversion of a string that contains a numeric address (e.g. "127.0.0.1", "127.0.0.1:8333", "[::1]:8333", ...) to a CService.

Thanks, this would be a great help!

So this check would cover IPv4 and IPv6 addresses ... are (in general) hostnames possible as a proxy input and how could I check that?

This is fixed with current master (which allows IPv6 addresses) and so can be closed!