I think the default behavior should be to fail and not silent return.
(A caller has always the choice to catch in case this is needed anywhere.)
[qa] mininode: fail on send_message instead of silent return #8214
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1606-qaMininodeAssert changing 1 files +1 −1-
MarcoFalke commented at 11:32 AM on June 17, 2016: member
-
[qa] mininode: fail on send_message instead of silent return facb6c0bf8
- MarcoFalke added the label Tests on Jun 17, 2016
-
laanwj commented at 11:57 AM on June 17, 2016: member
I tend to agree, better to be explicit.
ACK if this passes travis.
-
sdaftuar commented at 1:39 PM on June 17, 2016: member
Agreed, utACK
- MarcoFalke merged this on Jun 17, 2016
- MarcoFalke closed this on Jun 17, 2016
- MarcoFalke referenced this in commit ed2cd59e25 on Jun 17, 2016
- MarcoFalke deleted the branch on Jun 17, 2016
- codablock referenced this in commit d4ca784d59 on Sep 16, 2017
- codablock referenced this in commit ec7c281434 on Sep 19, 2017
- codablock referenced this in commit dd8b0a894d on Dec 27, 2017
- codablock referenced this in commit 6227cfdad5 on Dec 28, 2017
- sickpig referenced this in commit 101c642563 on Mar 9, 2018
- sickpig referenced this in commit a889a3d9a3 on Mar 9, 2018
- sickpig referenced this in commit ed5b5eac84 on Mar 12, 2018
- sickpig referenced this in commit 4f85eca0f9 on Mar 12, 2018
- sickpig referenced this in commit c30f7fcaa7 on Mar 12, 2018
- sickpig referenced this in commit 40bc0128d2 on Mar 12, 2018
- sickpig referenced this in commit 330553f4a5 on Mar 12, 2018
- andvgal referenced this in commit 8f23d9b551 on Jan 6, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels