Are you going to add Trezor support? #8218

issue ghost openend this issue on June 18, 2016
  1. ghost commented at 10:08 am on June 18, 2016: none

    Here’s the list of the clients which support Trezor hardware. http://doc.satoshilabs.com/trezor-apps/index.html

    Is Core going to support it?

  2. laanwj added the label Wallet on Jun 18, 2016
  3. laanwj commented at 2:52 pm on June 18, 2016: member

    Who are you asking?

    In any case: support for hardware wallets would certainly be welcome, if someone implements it.

  4. luke-jr commented at 4:48 pm on June 18, 2016: member
    This is really something you should be asking SatoshiLabs. Core has supported the HD wallet primitives that would be needed to support hardware wallets since a few years now, they just haven’t written the driver code.
  5. ghost commented at 6:08 pm on June 18, 2016: none

    I searched for it, and I found the answer is “No”

    Are you open for a (sort of) plugin of trezor with Bitcoin Core wallet/Bitcoin XT?

    It is technically doable, but it’s not in our pipeline for now. We do not see Core as a software ready for common users. Even Core developers said they may eventually remove Wallet from the code, because it it hard to maintain such monolithic code. I rarely agree with them; Core should be just an minimalistic implementation of node enforcing network rules and keeping blockchain running. They should leave other parts of infrastructure to people with better skills for UX.

    Reference: https://forum.bitcoin.com/post10669.html?hilit=core#p10669

  6. unknown closed this on Jun 18, 2016

  7. ghost commented at 2:06 pm on June 19, 2016: none

    I asked Trezor and got this answer:

    Sorry, but that particular Core developer is bullshitting you. BIP32 was just added recently and BIP44 is still not ready in Core. We will not put any effort until this is implemented by Core.

    Reference: https://github.com/trezor/trezor-mcu/issues/94#issuecomment-226996490

  8. sipa commented at 2:19 pm on June 19, 2016: member

    @luke-jr It’s not very reasonable to say that it’s just driver code that’s missing. Sure, BIP32 derivation primitives have been implemented for years, but as long as the wallet does not actually use it for its keys, it would be pretty hard to support.

    Of course, anyone is welcome to help move things forward with deterministic wallet and hardware wallet support.

  9. jonasschnelli commented at 6:02 pm on June 19, 2016: contributor

    Since fundrawtransaction supporting custom change addresses (merged recently #7518) hardware wallets like Trezor or the Digital Bitbox could provide a little client/driver that would allow using Bitcoin-Core together with a transaction signing over a different tool.

    I’m also working (extremely low prio, since fall 15) on a BIP for a “detached signing” standard. I think the current wallet approaches (Copay, Electrum) to support multiple native USB implementations is bad and what we need is a standard in how wallets-application could interact with hardware wallets.

    BIP32 is somehow required, but I could imaging it would also work with importing n addresses from a hardware wallet.

    IMO Cores wallet should have a mode where all transaction signing is somehow asynchronous and in that more each signature will be requested over an interface (pipe / raw TCP / ZMQ / http [my preferred way]). Each hardware wallet could provide an interface together with an optional UI and other wallets could also use this “standard communication interface”.

  10. micressor commented at 3:03 pm on March 24, 2017: none
    @jonasschnelli: When I understand you right, something like trezord may be such client/driver?
  11. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me