BUG: bitcoin-qt crash #8256

pull fsb4000 wants to merge 1 commits into bitcoin:master from fsb4000:patch-4 changing 1 files +2 −0

fsb4000 commented at 10:24 AM on June 24, 2016: contributor
How to reproduce bug:
1. Run bitcoin-qt which doen't have transactions. (any mode, here testnet screenshot but same problem with mainnet)
2. Press right mouse button at center:
3. Program crashes:
I found that error at the line:
```
hash.SetHex(selection.at(0).data(TransactionTableModel::TxHashRole).toString().toStdString());
```
and I added the check.

My system: Linux Mint 18, Qt 5.5
laanwj added the label GUI on Jun 24, 2016
laanwj added the label Bug on Jun 24, 2016
laanwj commented at 10:34 AM on June 24, 2016: member

Good catch! I take it that "АВарийный останов" is a "Segmentation Fault" in Russian (Google translates it as "Emergency Stop")? utACK https://github.com/bitcoin/bitcoin/pull/8256/commits/59b861b0dd4e5be5cb3dccc6a514d4904dd3c91a
MarcoFalke commented at 10:36 AM on June 24, 2016: member

Concept ACK. Thanks for adding steps to reproduce!
check that transactionView->selectionModel()->selectedRows(0) exists d7828abd5b

in src/qt/transactionview.cpp:None in 59b861b0dd outdated

 362 | @@ -363,6 +363,9 @@ void TransactionView::exportClicked()
 363 |  
 364 |  void TransactionView::contextualMenu(const QPoint &point)
 365 |  {
 366 | +    if (transactionView->selectionModel()->selectedRows().count() == 0)
 367 | +        return;
 368 | +    
 369 |      QModelIndex index = transactionView->indexAt(point);
 370 |      QModelIndexList selection = transactionView->selectionModel()->selectedRows(0);

laanwj commented at 10:41 AM on June 24, 2016:

nit: you could move this down two lines and do:

if (selection.empty())
    return;

jonasschnelli commented at 11:33 AM on June 24, 2016: contributor

Thanks. Seems necessary. utACK d7828ab.
laanwj merged this on Jun 24, 2016
laanwj closed this on Jun 24, 2016
laanwj referenced this in commit af2421c291 on Jun 24, 2016
codablock referenced this in commit 30c269aefe on Sep 19, 2017
UdjinM6 referenced this in commit 3b327c8ef0 on Dec 20, 2017
UdjinM6 referenced this in commit c67f3693ed on Dec 21, 2017
UdjinM6 referenced this in commit 37de4368cf on Dec 26, 2017
UdjinM6 referenced this in commit ecedcfe9ee on Dec 26, 2017
codablock referenced this in commit e190674b2b on Dec 27, 2017
codablock referenced this in commit 3f7273d009 on Dec 28, 2017
sidhujag referenced this in commit e1172ca545 on Jan 2, 2018
UdjinM6 referenced this in commit 068b20bc70 on Jan 5, 2018
NarubyRiverlione referenced this in commit 43c8a74b81 on Feb 4, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels