RPC: Hide softfork if timeout is 0 #8258

pull jl2012 wants to merge 1 commits into bitcoin:master from jl2012:bip9rpcdisable changing 1 files +12 −3
  1. jl2012 commented at 4:58 PM on June 24, 2016: contributor

    Replace #8209

    getblockchaininfo will not show a BIP9 proposal if the timeout is 0. A timeout before the genesis block timestamp guarantees that a softfork must not be activated in any circumstances. A timeout of 0 should be used when we want to merge a softfork proposal without defining its deployment schedule

  2. RPC: Hide softfork if timeout is 0 409f83322e
  3. paveljanik commented at 7:48 PM on June 24, 2016: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/8258/commits/409f83322e9fe3257cf9f3f61813195ac1aaa20c

    Without this change, the current master shows (RPC getblockchaininfo):

        "segwit": {
          "status": "failed",
          "startTime": 0,
          "timeout": 0
        }
    
  4. sipa commented at 7:54 PM on June 24, 2016: member

    ACK

  5. MarcoFalke added this to the milestone 0.13.0 on Jun 25, 2016
  6. MarcoFalke added the label RPC/REST/ZMQ on Jun 25, 2016
  7. dcousens commented at 3:07 AM on June 27, 2016: contributor

    ACK 409f833

  8. laanwj merged this on Jun 27, 2016
  9. laanwj closed this on Jun 27, 2016

  10. laanwj referenced this in commit 5a06ebbf2d on Jun 27, 2016
  11. laanwj added the label Needs backport on Jun 28, 2016
  12. laanwj commented at 2:08 PM on June 28, 2016: member

    This needs backport to 0.12, but will only merge cleanly after segwit.

  13. jl2012 commented at 5:20 PM on June 28, 2016: contributor

    @laanwj I don't think a backport is needed since we won't release a backport with undefined softfork

  14. laanwj commented at 8:51 AM on June 29, 2016: member

    OK

  15. laanwj removed the label Needs backport on Jun 29, 2016
  16. codablock referenced this in commit 392f4e8584 on Sep 19, 2017
  17. codablock referenced this in commit 63dcb58889 on Dec 27, 2017
  18. codablock referenced this in commit 7f5b8f1e1d on Dec 28, 2017
  19. andvgal referenced this in commit 3e335ea26d on Jan 6, 2019
  20. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me