src: Fix spelling error in comment - netbase.h #8265

pull wbnns wants to merge 1 commits into bitcoin:master from wbnns:bitcoiner-fix-typo-netbase changing 1 files +1 −1

wbnns commented at 11:42 PM on June 25, 2016: none
This PR contains one commit that fixes a spelling error in one of the in-line comments in src/netbase.h:
- communcations should be spelled communications

src: Fix spelling error in comment - netbase.h

This commit fixes a spelling error in one of the in-line comments
in src/netbase.h:
+ "communcations" should be spelled "communications"

105072e79b

MarcoFalke commented at 12:24 AM on June 26, 2016: member

Please fix all typos in one commit. No need to open several pull request.
paveljanik commented at 5:13 AM on June 26, 2016: contributor

Trivial ACK https://github.com/bitcoin/bitcoin/pull/8265/commits/105072e79bc9e5e981066e4f189de144ef246744
wbnns commented at 2:55 PM on June 26, 2016: none

@paveljanik @MarcoFalke Thanks for the review. @MarcoFalke Thanks also for the feedback regarding one PR. Also, apologies - I wasn't sure if it was better to do these individually since these are sensitive files. I'll finish my review of all of the files, cherry pick this one in to the previous PR and squash any spelling fixes into one commit.

I hope you all are having a nice weekend. 👍
jonasschnelli commented at 8:10 PM on June 26, 2016: contributor

ACK and agree with @MarcoFalke: please combine multiple comment changes in one PR.
jonasschnelli added the label Docs and Output on Jun 26, 2016
MarcoFalke commented at 9:55 PM on June 26, 2016: member

Closing per discussion
MarcoFalke closed this on Jun 26, 2016
wbnns commented at 3:02 PM on June 27, 2016: none

@jonasschnelli @MarcoFalke Ok, thanks guys.
laanwj commented at 7:43 AM on June 28, 2016: member

Posthumous ACK, but yes better to combine these into one PR
MarcoFalke commented at 8:37 AM on June 28, 2016: member

@wbinns I hope it is ok for you that I leave this pull closed. If you find more spelling errors, feel free to open a new pull with the new ones (including the one from this pull).

In any case, I was planning to fix several trivial issues in a pull later this week when I find time. I will make sure to include your patch as well.
wbnns commented at 11:47 AM on June 28, 2016: none

@MarcoFalke Ok, yes sir, absolutely. Thanks!
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels