As per meeting 2016-03-31 https://bitcoincore.org/en/meetings/2016/03/31/#bad-chain-alerts
The partition checker was producing huge number of false-positives and was disabled in 0.12.1 on the understanding it would either be fixed in 0.13 or removed entirely from master if not.
As per meeting 2016-03-31
https://bitcoincore.org/en/meetings/2016/03/31/#bad-chain-alerts
The partition checker was producing huge number of false-positives
and was disabled in 0.12.1 on the understanding it would either be
fixed in 0.13 or removed entirely from master if not.
You are also removing the tests, so something like #7568 would require to add them back later.
Yes removing the code entirely is a more final option, though it could be re-added if something better pops up.
Which to choose that depends. If this is just due to lack of review time / too many high-priority issues pre-0.13, which was my guess, it makes sense to postpone the deadline to 0.14 and do #8241 in the meantime.
But if it is considered a bad, broken idea and no one is motivated to look at this at all, it's better to remove it and do this.
It's not like we're deleting it from git history, and disabled code has a tendency to break further anyway.
Concept ACK