Bugfix: Allow building libbitcoinconsensus without any univalue #8293

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:sys_univalue_opt changing 1 files +13 −3

luke-jr commented at 1:52 AM on June 30, 2016: member

No description provided.
theuni commented at 7:45 AM on June 30, 2016: member
Concept ACK. A few nits:
- Please store the test as build_no_programs or build_libs_only or so, so that we only need the ugly xnononono stuff in one place.
- I'd rather not abuse system_univalue that way, as it's not obvious what it's doing. Please change that to configure_embedded_univalue or so, and rework the test as necessary.
laanwj added the label Build system on Jun 30, 2016
luke-jr commented at 3:31 PM on June 30, 2016: member

It's conceivable that at some point bitcoin-tx could be freed of the univalue dependency as well, so I'm not sure it makes sense to do the dedicated var?
laanwj commented at 8:05 AM on July 1, 2016: member

I don't think that's realistic. bitcoin-tx uses JSON objects in various places in the interface
theuni commented at 4:08 PM on July 6, 2016: member

@luke-jr My only concern is that "system_univalue" should not be equated to "don't use any univalue". renaming to need_univalue would suffice.
laanwj commented at 9:48 AM on August 3, 2016: member

Ok, let's rename it then.
luke-jr force-pushed on Aug 9, 2016
luke-jr force-pushed on Aug 9, 2016
luke-jr commented at 5:30 AM on August 9, 2016: member

Renamed.
Bugfix: Allow building libbitcoinconsensus without any univalue 8a270b25fc
luke-jr force-pushed on Aug 9, 2016
theuni commented at 7:29 PM on August 12, 2016: member

Thanks. utACK.
laanwj merged this on Aug 13, 2016
laanwj closed this on Aug 13, 2016
laanwj referenced this in commit efce84d888 on Aug 13, 2016
jgarzik commented at 2:43 PM on August 13, 2016: contributor

ut ACK
luke-jr commented at 8:03 AM on September 10, 2016: member

Needs backport to 0.13.
luke-jr referenced this in commit fa5b2498ca on Sep 21, 2016
codablock referenced this in commit ec2638f060 on Sep 19, 2017
codablock referenced this in commit ec9de8b65e on Dec 29, 2017
codablock referenced this in commit cca05694c5 on Jan 8, 2018
andvgal referenced this in commit f0937d71a0 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels