[wallet] {dump,import}wallet incompatible with HD #8308

issue MarcoFalke opened this issue on July 6, 2016
  1. MarcoFalke commented at 6:11 PM on July 6, 2016: member

    I am assuming dumpwallet and importwallet no longer work when -usehd is set. This should be mentioned somewhere because it may not be obvious.

  2. MarcoFalke added the label Wallet on Jul 6, 2016
  3. MarcoFalke added this to the milestone 0.13.0 on Jul 6, 2016
  4. MarcoFalke commented at 7:20 PM on July 6, 2016: member

    Apparently there is already something ready for review: #8206

  5. laanwj commented at 5:21 AM on July 7, 2016: member

    That's a good point.

    importwallet could somewhat-work, I don't think the hd wallet forbids importing keys?

  6. jonasschnelli commented at 6:31 AM on July 7, 2016: contributor

    importwallet works in conjunction with HD and IMO it does exactly what it should (importing a wallet/keys but not importing the hd seed not activating the hdseed). The later could be discussed.

    One could "import" multiple wallets and I think re-activatig the HD seed would be wrong in this case.

    Edit: "it does import the seed but it does not activate it"

  7. MarcoFalke commented at 7:07 AM on July 7, 2016: member

    One could "import" multiple wallets and I think re-activatig the HD seed would be wrong in this case.

    I feel like it should be at least documented that HD-seeds are not activated. This may not be obvious to everyone.

    Something nice to have for 0.14: Warn when importwallet finds a HD seed, because it can not be activated in neither case. Having your current wallet be a legacy wallet, it would be not intuitive to suddenly switch to a HD wallet; And having your current wallet be a HD wallet, you can not import another HD seed...

  8. sipa commented at 8:20 AM on July 7, 2016: member

    We could also just write the HD seed to the dump...

  9. jonasschnelli commented at 8:58 AM on July 7, 2016: contributor

    We could also just write the HD seed to the dump...

    #8206 does that.

  10. MarcoFalke added the label Docs and Output on Jul 8, 2016
  11. laanwj removed this from the milestone 0.13.0 on Jul 18, 2016
  12. MarcoFalke closed this on Jul 21, 2016

  13. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me