No description provided.
[qa] Add wallet-hd test #8309
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1607-qaHD changing 3 files +82 −0-
MarcoFalke commented at 6:18 PM on July 6, 2016: member
- MarcoFalke added the label Wallet on Jul 6, 2016
- MarcoFalke added the label Tests on Jul 6, 2016
- MarcoFalke added this to the milestone 0.13.0 on Jul 6, 2016
-
[qa] test_framework: Add wrapper for stop_node fa9976b853
- MarcoFalke force-pushed on Jul 7, 2016
-
[qa] Add wallet-hd test fade505e8b
-
in qa/rpc-tests/wallet-hd.py:None in 7d573c7ec9 outdated
66 | + hd_add_2 = self.nodes[1].getnewaddress() 67 | + assert_equal(hd_add, hd_add_2) 68 | + 69 | + # Needs rescan? 70 | + self.stop_node(1) 71 | + self.nodes[1] = start_node(1, self.options.tmpdir, self.node_args[1].extend(['-rescan']))
jonasschnelli commented at 7:52 PM on July 7, 2016:This won't trigger a rescan. It should be
self.node_args[1] + ['-rescan'].self.node_args[1].extend(['-rescan'])results innull?.
MarcoFalke commented at 8:06 PM on July 7, 2016:Awesome! It is always good to have fresh eyes look on the code.
Will push a fix and then squash the commits.
MarcoFalke force-pushed on Jul 7, 2016jonasschnelli commented at 7:31 AM on July 8, 2016: contributorThanks for the test! Tested ACK fade505e8b0fa37e2d99bf94259250271a9604d4
laanwj commented at 7:57 AM on July 8, 2016: memberThanks for the test @MarcoFalke and thanks for investigating the issue so quickly during the meeting yesterday @jonasschnelli ACK fade505
laanwj merged this on Jul 8, 2016laanwj closed this on Jul 8, 2016laanwj referenced this in commit bb2646aea0 on Jul 8, 2016MarcoFalke deleted the branch on Jul 8, 2016str4d referenced this in commit 73fc95918c on Mar 24, 2020zkbot referenced this in commit b2ab91b032 on Mar 24, 2020str4d referenced this in commit b0d81be4cd on Mar 24, 2020zkbot referenced this in commit 38755ebc22 on Mar 24, 2020zkbot referenced this in commit da12da80c4 on Apr 2, 2020zkbot referenced this in commit 1be7250db9 on Apr 3, 2020DrahtBot locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me