Rename CTxinWitness -> CTxInWitness #8311

1. 
   mcelrath commented at 12:06 AM on July 7, 2016: none

   ...in order to match the convention used elsewhere CTxIn (notice the capital 'I').

   I'm mirroring these changes into python-bitcoinlib, which keeps all the same class names as Bitcoin Core. This incongruity in naming stuck out to me.

2. Rename CTxinWitness -> CTxInWitness 36ae37a9f9
3. 
   petertodd commented at 3:40 PM on July 7, 2016: contributor

   Concept ACK

   I don't really care what color the bikesheds are painted, but can we please just use the same colour again? :)

4. 
   dcousens commented at 1:46 AM on July 8, 2016: contributor

   utACK 36ae37a

5. MarcoFalke added the label Refactoring on Jul 8, 2016
6. 
   mcelrath commented at 3:34 PM on July 8, 2016: none

   Tested ACK

   Been running this since shortly before I made the PR.

7. 
   paveljanik commented at 8:33 PM on July 8, 2016: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/8311/commits/36ae37a9f910922954d48ed1f3f2177d8b227205

8. 
   laanwj commented at 12:35 PM on July 11, 2016: member

   Indeed, the precedent seems to be CTxIn. @sipa do you agree with this naming change?

   If we do this it should be merged before 0.13 to avoid having different spellings in different releases.

9. laanwj added this to the milestone 0.13.0 on Jul 11, 2016
10. 
    petertodd commented at 12:08 AM on July 13, 2016: contributor

    @laanwj ack 0.13.0 milestone - I'd like to have naming consistent in python-bitcoinlib too.

11. laanwj merged this on Jul 14, 2016
12. laanwj closed this on Jul 14, 2016

    ---

13. laanwj referenced this in commit 4324bd237c on Jul 14, 2016
14. 
    laanwj commented at 6:19 AM on July 14, 2016: member

    trivial-ACK 36ae37a

15. DrahtBot locked this on Sep 8, 2021

Milestone
0.13.0