[qa] wallet*.py: Check for salvagewallet regressions #8319

1. 
   MarcoFalke commented at 4:33 PM on July 8, 2016: member

   This checks for the bug reported in #2480 and #8300.

2. MarcoFalke added the label Wallet on Jul 8, 2016
3. MarcoFalke added the label Tests on Jul 8, 2016
4. 
   paveljanik commented at 6:03 PM on July 12, 2016: contributor

   wallet.py fails tests.

5. MarcoFalke renamed this:
   [qa] wallet*.py: Check for salvagewallet regressions
   [WIP] [qa] wallet*.py: Check for salvagewallet regressions
   on Jul 12, 2016
6. 
   laanwj commented at 9:39 AM on July 14, 2016: member

   Re-triggered travis after merging #8324 Ok, passes locally, and in travis as well. WIP tag can go?

7. MarcoFalke renamed this:
   [WIP] [qa] wallet*.py: Check for salvagewallet regressions
   [qa] wallet*.py: Check for salvagewallet regressions
   on Jul 14, 2016
8. laanwj added this to the milestone 0.13.0 on Jul 14, 2016
9. in qa/rpc-tests/wallet.py:None in 9999e79d59 outdated

    329 | @@ -330,7 +330,12 @@ def run_test (self):
    330 |              '-zapwallettxes=2',
    331 |              # disabled until issue is fixed: https://github.com/bitcoin/bitcoin/issues/7463
    332 |              # '-salvagewallet',
    333 | +            # enabled to check for regression: https://github.com/bitcoin/bitcoin/issues/2480
   

   ---

   ---

   

   laanwj commented at 7:15 AM on July 15, 2016:

   this conflicts with the above comment

   ---

   

   MarcoFalke commented at 7:19 AM on July 15, 2016:

   This is on purpose. Not sure how to proceed.

10. 
    MarcoFalke commented at 7:24 AM on July 15, 2016: member

    Don't consider this pull a blocker for rc1. It should test the regression well enough for now but there might be things to improve and work on later. You can merge it now or leave it for later. I shouldn't matter too much, maybe flip a coin?

11. 
    laanwj commented at 5:48 AM on July 18, 2016: member

    Right - going to remove this from the milestone, I don't think we should re-enable a -salvagewallet test as long as we have #7463.

12. laanwj removed this from the milestone 0.13.0 on Jul 18, 2016
13. [qa] wallet*.py: Check for salvagewallet regressions 0dd8cb3fbe
14. MarcoFalke force-pushed on Aug 20, 2016
15. 
    sipa commented at 2:46 PM on April 9, 2017: member

    What is blocking this? It seems #7463 is still open.

16. 
    MarcoFalke commented at 9:22 AM on April 16, 2017: member

    Yes, I think this is still relevant. I will put it on my list for 0.15. It seems that I need to catch up with the recent hdwallet changes first. Closing for now.

17. MarcoFalke closed this on Apr 16, 2017

    ---

18. MarcoFalke added this to the milestone 0.15.0 on Apr 16, 2017
19. MarcoFalke deleted the branch on Apr 29, 2018
20. MarcoFalke locked this on Sep 8, 2021

Contributors

MarcoFalkepaveljaniklaanwjsipa

Milestone
0.15.0