semi trivial: clarify witness branches in transaction.h serialization #8332

pull dcousens wants to merge 1 commits into bitcoin:master from dcousens:patch-1 changing 1 files +5 −3

dcousens commented at 3:28 AM on July 12, 2016: contributor

In reading through this, I found it much easier to read/reason about the branches without having to double check the double negation and relevant syntax by just having this more readable variable.

hasWitness might be misleading, since the witness flag could still be missing. Perhaps supportsWitness or witnessCompatible?
jonasschnelli added the label Refactoring on Jul 12, 2016
jonasschnelli commented at 12:09 PM on July 12, 2016: contributor

Trivial utACK 744526fec097821a78529386ada81ae844f7183a
NicolasDorier commented at 3:02 PM on July 12, 2016: contributor

Trivial utACK 744526f, I think supportsWitness may be better though, if you are not too lazy to change it. :p
sipa commented at 5:43 PM on July 12, 2016: member

utACK after squash. allowWitness is fine by me.
paveljanik commented at 5:46 PM on July 12, 2016: contributor

fAllowWitness?
dcousens commented at 3:40 AM on July 14, 2016: contributor

Rebased and squashed w/ fAllowWitness
transaction: clarify witness branches e37b16a75c
paveljanik commented at 7:05 AM on July 14, 2016: contributor

trivial ACK https://github.com/bitcoin/bitcoin/pull/8332/commits/e37b16a75c1ff86d515ef3050d2c76432ea71225
jtimon commented at 3:43 PM on July 18, 2016: contributor

ACK e37b16a (didn't tested but it's obviously correct).
MarcoFalke commented at 3:45 PM on July 18, 2016: member

utACK e37b16a75c1ff86d515ef3050d2c76432ea71225
laanwj merged this on Jul 28, 2016
laanwj closed this on Jul 28, 2016
laanwj referenced this in commit 806b9e7570 on Jul 28, 2016
dcousens deleted the branch on Jul 28, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels